Skip to content

fix: disable warnings about missing env variables if users passes them explicitly in the code [DC-4217] #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 6, 2025
Merged

fix: disable warnings about missing env variables if users passes them explicitly in the code [DC-4217] #264

merged 9 commits into from
Jun 6, 2025

Conversation

faymarie
Copy link
Contributor

@faymarie faymarie commented Jun 5, 2025

Related Issues

Proposed Changes?

How did you test it?

Notes for the reviewer

Screenshots (optional)

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

Marie-Luise Klaus added 2 commits June 5, 2025 18:10
@faymarie faymarie requested a review from a team as a code owner June 5, 2025 16:25
@faymarie faymarie requested a review from ArzelaAscoIi June 5, 2025 16:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  deepset_cloud_sdk/_api
  config.py
Project Total  

This report was generated by python-coverage-comment-action

@faymarie faymarie changed the title fix: disable warnings about missing env variables if users passes them directly [DC-4217] fix: disable warnings about missing env variables if users passes them explicitly in the code [DC-4217] Jun 6, 2025
ArzelaAscoIi
ArzelaAscoIi approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@faymarie faymarie added this pull request to the merge queue Jun 6, 2025
Merged via the queue into main with commit 3dca355 Jun 6, 2025
9 checks passed
@faymarie faymarie deleted the fix/pipeline-service-with-api-params-precedence branch June 6, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArzelaAscoIi ArzelaAscoIi ArzelaAscoIi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faymarie @ArzelaAscoIi