-
Notifications
You must be signed in to change notification settings - Fork 2
feat: enable publishing pipelines and indexes to deepset AI platfrom #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
deepset_cloud_sdk/workflows/user_facing_docs/pipeline_service_docs.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good already! Some comments about the DX. Looking forward to have this feature!
(Iiiiiif you could add an integration tests that actually pushes a pipeline to the cloud, would be amazing btw.)
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
deepset_cloud_sdk/workflows/user_facing_docs/pipeline_service_docs.py
Outdated
Show resolved
Hide resolved
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left more general comments as of now.
In general very good first throw! I especially like the naming (publish
, workflows
) and it's already fairly intuitive!
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Tobias Wochinger <tobias.wochinger@deepset.ai>
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few smaller questions but looks good to me already.
What are the next steps? Secrets & OpenSearch?
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
deepset_cloud_sdk/workflows/pipeline_client/pipeline_service.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
Related Issues
Proposed Changes?
Allows adding Haystack Pipeline and AsyncPipeline as Pipeline or Index to deepset AI platform as a ymal string.
Adds inputs and outputs.
Secrets, AnswerBuilder, DocumentStores, return values etc will be managed in separate PRs!
How did you test it?
Notes for the reviewer
Screenshots (optional)
Checklist