Skip to content

feat: Implement global event handlers #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Jul 4, 2024
Merged

feat: Implement global event handlers #64

merged 30 commits into from
Jul 4, 2024

Conversation

karllu3
Copy link
Contributor

@karllu3 karllu3 commented Jun 24, 2024

No description provided.

@karllu3 karllu3 linked an issue Jun 24, 2024 that may be closed by this pull request
feat: use globals event handlers for all db-ally collections #63
Closed
@karllu3 karllu3 changed the title Feat: Implement global event handlers feat: Implement global event handlers Jun 24, 2024
@karllu3 karllu3 marked this pull request as draft June 24, 2024 18:35
@micpst micpst added the feature New feature or request label Jun 25, 2024
@github-actions GitHub Actions
Copy link

Trivy scanning results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                                                  Stmts    Miss  Cover    Missing
------------------------------------------------------  -------  ------  -------  ---------------------------------------------------------------------
dbally/_main.py                                              13       1  92.31%   10
dbally/_types.py                                              8       1  87.50%   24
dbally/exceptions.py                                          1       0  100.00%
dbally/assistants/base.py                                    24       0  100.00%
dbally/assistants/openai.py                                  59       2  96.61%   59-76
dbally/audit/event_tracker.py                                36       8  77.78%   38-40, 53, 64, 74, 91, 97
dbally/audit/events.py                                       28       0  100.00%
dbally/audit/spans.py                                         7       0  100.00%
dbally/audit/event_handlers/base.py                          15       0  100.00%
dbally/audit/event_handlers/buffer_event_handler.py           8       8  0.00%    1-28
dbally/audit/event_handlers/cli_event_handler.py             52      33  36.54%   11-13, 43-44, 47-55, 65-66, 79-90, 108-115, 126-130
dbally/audit/event_handlers/langsmith_event_handler.py       29      25  13.79%   6-106
dbally/collection/collection.py                              85       0  100.00%
dbally/collection/exceptions.py                              13       0  100.00%
dbally/collection/results.py                                 14       0  100.00%
dbally/embeddings/base.py                                     5       0  100.00%
dbally/embeddings/exceptions.py                              15       6  60.00%   10-11, 20, 29-30, 39
dbally/embeddings/litellm.py                                 28      12  57.14%   7-8, 44, 68-84
dbally/gradio/gradio_interface.py                           111     111  0.00%    1-300
dbally/iql/_exceptions.py                                    25       1  96.00%   35
dbally/iql/_processor.py                                     79       7  91.14%   16, 47, 64, 70, 76, 85, 91
dbally/iql/_query.py                                         17       1  94.12%   8
dbally/iql/_type_validators.py                               38       2  94.74%   24, 28
dbally/iql/syntax.py                                         36       9  75.00%   6-9, 27, 36, 60, 63-66
dbally/iql_generator/iql_generator.py                        25       0  100.00%
dbally/iql_generator/prompt.py                               16       1  93.75%   33
dbally/llms/base.py                                          28       1  96.43%   34
dbally/llms/litellm.py                                       24      10  58.33%   8-9, 48-54, 61, 78
dbally/llms/local.py                                         18      18  0.00%    1-60
dbally/llms/clients/base.py                                  23       2  91.30%   46-47
dbally/llms/clients/exceptions.py                            15       6  60.00%   10-11, 20, 29-30, 39
dbally/llms/clients/litellm.py                               44      21  52.27%   8-9, 65-71, 97-120
dbally/llms/clients/local.py                                 33      33  0.00%    1-95
dbally/nl_responder/nl_responder.py                          24       4  83.33%   71-82
dbally/nl_responder/prompts.py                               19       4  78.95%   64-67
dbally/prompt/elements.py                                    25       1  96.00%   29
dbally/prompt/template.py                                    65       7  89.23%   33, 41, 49, 110, 127, 153, 205
dbally/similarity/chroma_store.py                            37       0  100.00%
dbally/similarity/elastic_vector_search.py                   19      16  15.79%   5-102
dbally/similarity/elasticsearch_store.py                     22      19  13.64%   5-107
dbally/similarity/faiss_store.py                             38      35  7.90%    5-103
dbally/similarity/fetcher.py                                  5       0  100.00%
dbally/similarity/index.py                                   26       0  100.00%
dbally/similarity/sqlalchemy_base.py                         44      19  56.82%   35-37, 46, 68, 77, 86-89, 99-105, 123-126
dbally/similarity/store.py                                    7       0  100.00%
dbally/view_selection/base.py                                 7       0  100.00%
dbally/view_selection/llm_view_selector.py                   17       0  100.00%
dbally/view_selection/prompt.py                               9       0  100.00%
dbally/view_selection/random_view_selector.py                10      10  0.00%    1-36
dbally/views/base.py                                         16       1  93.75%   52
dbally/views/decorators.py                                    6       0  100.00%
dbally/views/exposed_functions.py                            33       1  96.97%   24
dbally/views/methods_base.py                                 34       2  94.12%   75, 83
dbally/views/pandas_base.py                                  33       1  96.97%   64
dbally/views/sqlalchemy_base.py                              37       7  81.08%   48, 63-65, 83-87
dbally/views/structured.py                                   38       0  100.00%
dbally/views/freeform/text2sql/config.py                     21       1  95.24%   47
dbally/views/freeform/text2sql/exceptions.py                  7       3  57.14%   12-14
dbally/views/freeform/text2sql/prompt.py                     11       0  100.00%
dbally/views/freeform/text2sql/view.py                       93      22  76.34%   49, 52, 55, 58, 61, 73, 151, 155-158, 161, 191, 203-204, 212, 225-230
dbally_cli/main.py                                            5       5  0.00%    1-13
dbally_cli/text2sql.py                                       94      94  0.00%    1-248
dbally_codegen/autodiscovery.py                             122      18  85.25%   54-57, 241-243, 264-278, 281-284, 353-354, 450-455
dbally_codegen/generator.py                                 175       7  96.00%   81, 91, 314, 342, 360, 374, 420
TOTAL                                                      2071     596  71.22%

Diff against main

Filename                                               Stmts    Miss  Cover
---------------------------------------------------  -------  ------  --------
dbally/_main.py                                           +1      +1  -7.69%
dbally/audit/event_tracker.py                             +2      +2  -4.57%
dbally/audit/event_handlers/buffer_event_handler.py       +8      +8  +100.00%
dbally/audit/event_handlers/cli_event_handler.py          -4      -2  -0.96%
dbally/collection/collection.py                           -1      -1  +1.16%
dbally/gradio/gradio_interface.py                         +6      +6  +100.00%
TOTAL                                                    +12     +14  -0.51%

Results for commit: 58b9ead

Minimum allowed coverage is 60%

♻️ This comment has been updated with latest results

@karllu3 karllu3 marked this pull request as ready for review June 25, 2024 16:55
@karllu3 karllu3 requested review from mhordynski and micpst June 25, 2024 16:55
patryk-wyzgowski
patryk-wyzgowski reviewed Jun 26, 2024
View reviewed changes
mhordynski
mhordynski reviewed Jul 2, 2024
View reviewed changes
mhordynski
mhordynski reviewed Jul 2, 2024
View reviewed changes
micpst
micpst reviewed Jul 2, 2024
View reviewed changes
micpst
micpst reviewed Jul 2, 2024
View reviewed changes
micpst
micpst reviewed Jul 4, 2024
View reviewed changes
mhordynski
mhordynski approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@mhordynski mhordynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhordynski mhordynski merged commit 221f6e1 into main Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhordynski mhordynski mhordynski approved these changes

@micpst micpst micpst approved these changes

+1 more reviewer

@patryk-wyzgowski patryk-wyzgowski patryk-wyzgowski left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@karllu3 karllu3

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: use globals event handlers for all db-ally collections
4 participants
@karllu3 @mhordynski @micpst @patryk-wyzgowski