fix: add CUDA include path for CCCL headers (CUDA 13+ compatibility) #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed `flash_mla_with_kvcache_sm90` to `flash_mla_with_kvcache` in get_mla_metadata docstring to match the actual function name. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
CUDA 13 moved cuda/std/utility and other standard library headers to CCCL (CUDA C++ Core Library). This adds the CUDA include path explicitly to resolve build errors on CUDA 13+ ARM64 systems. Fixes deepseek-ai#121 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
CUDA 13 moved
cuda/std/utilityand other standard library headers to CCCL (CUDA C++ Core Library). This causes build failures on ARM64 systems with CUDA 13+:Solution
Add
$CUDA_HOME/includeto the include directories so the compiler can find CCCL headers.Test plan
Fixes #121
🤖 Generated with Claude Code