fix: add backwards-compatible alias for deprecated parameter name #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds backwards compatibility for the renamed parameter in
get_mla_metadata(), addressing issue #108.Problem
The parameter name was changed from
num_heads_per_head_ktonum_q_tokens_per_head_k, breaking existing code that uses the old name.Solution
Add support for the old parameter name as a deprecated alias:
Changes
num_heads_per_head_kas keyword-only deprecated parameterDeprecationWarningwhen deprecated name is usedExample Warning
Test plan
get_mla_metadata(seqlens, 8, 1)get_mla_metadata(seqlens, num_q_tokens_per_head_k=8, num_heads_k=1)get_mla_metadata(seqlens, num_heads_per_head_k=8, num_heads_k=1)Fixes #108
🤖 Generated with Claude Code