Skip to content

Commit

Permalink
[yugabyte#13287] Enable codecheck for gen_flags_metadata.py
Browse files Browse the repository at this point in the history
Summary:
Add gen_flags_metadata.py to codecheck.ini
Use shlex_join in stabilize_auto_flags_list.py

Fixes yugabyte#13287

Test Plan: All builds

Reviewers: jhe

Reviewed By: jhe

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D20895
  • Loading branch information
hari90 committed Nov 8, 2022
1 parent 3fc6b59 commit d393877
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions build-support/stabilize_auto_flags_list.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import ruamel.yaml # type: ignore

sys.path.append(os.path.join(os.path.dirname(os.path.dirname(__file__)), 'python'))
from yb.common_util import YB_SRC_ROOT, create_temp_dir, init_logging # noqa: E402
from yb.common_util import YB_SRC_ROOT, create_temp_dir, init_logging, shlex_join # noqa: E402


def main() -> None:
Expand All @@ -32,7 +32,7 @@ def main() -> None:
"--write-build-descriptor", build_desc_path,
"--skip-java"
]
logging.info("Running build step:\n%s", ' '.join(build_cmd_list))
logging.info("Running build step:\n%s", shlex_join(build_cmd_list))
try:
subprocess.run(build_cmd_list, capture_output=True, check=True)
except subprocess.CalledProcessError as e:
Expand Down
1 change: 1 addition & 0 deletions codecheck.ini
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ included_regex_list =
^python/yb/dep_graph_common[.]py$
^python/yb/dependency_graph[.]py$
^python/yb/gen_auto_flags_json[.]py$
^python/yb/gen_flags_metadata[.]py$
^python/yb/library_packager[.]py$
^python/yb/linuxbrew[.]py$
^python/yb/lto[.]py$
Expand Down

0 comments on commit d393877

Please sign in to comment.