Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 18, 2025

This PR contains the following updates:

Package Change Age Confidence
@vscode/extension-telemetry ^0.7.7 -> ^0.9.0 age confidence

Release Notes

Microsoft/vscode-extension-telemetry (@​vscode/extension-telemetry)

v0.9.9

Compare Source

Changes:

  • #​224: bump version
  • #​223: add node-esm variant
  • #​221: Remove extra brace from common.platformversion
  • #​220: Bump serialize-javascript and mocha
  • #​219: classify new property

This list of changes was auto generated.

v0.9.8

Compare Source

Changes:

  • #​218: Bump version for release
  • #​216: Accept instrumentation and connection string
  • #​215: Propagate session ID metadata

This list of changes was auto generated.

v0.9.7

Compare Source

Changes:

  • #​213: Bump version + packages
  • #​211: Update readme + support connection string
  • #​210: Send user id in extension paylod
  • #​207: Bump braces from 3.0.2 to 3.0.3
  • #​206: Update packages
  • #​204: Rollback packages

This list of changes was auto generated.

v0.9.6

Compare Source

v0.9.5

Compare Source

v0.9.4: Align measurements with properties

Compare Source

  • Allows measurements to also be undefined for easy omitting, similar to how properties work

v0.9.3: Improved user agent

Compare Source

  • Improves on the user agent metric shown when navigator.userAgentData is unavailable. Thanks to @​sezna
  • Fixes a bug with telemetry fetching using app insights on older version of node. Thanks to @​devm33

v0.9.2: Global Privacy Control compliance fixes

Compare Source

This release contains a small fix to the 1DS package used by Microsoft extensions in the web to ensure compliance with the California's Global Privacy Control. If you're not a Microsoft extension, then it is safe to disregard this release as it contains no new features or improvements for the third party flow.

v0.9.1: Fix unhandlederror common props.

Compare Source

Thanks to a community contribution by @​ilia-db the unhandlederror event handler has been properly fixed to include common properties.

v0.9.0: Use app insights basics versus the complete app insights package to reduce bundle size

Compare Source

Application insights web basics comes with the ability to pass in a fetch pollyfill that allows it to be used for both Node and Web. This is similar to what we already do for first party extensions using the 1DS package.

While there is no breaking changes here, the replacement of a key dependency with what should be an equivalent alternative may have unknown edge cases that were not accounted for, therefore the version has been bumped to reflect this.

Bundlephobia reports a 67Kb decline in bundle size with this change.

v0.8.5: Improve shutdown performance

Compare Source

  • Improves shutdown performance by lessening the amount of time which is allocated to disposing the telemetry reporters. Additionally, removes a few redundant flushes. Fixes microsoft/vscode#192742

v0.8.4: Fix data loss on connection loss

Compare Source

  • Fixes a bug where if the user's connection were to drop during a session, telemetry would no longer send for the rest of that session
  • Fixes a bug with sendRawTelemetryEvent sending key: key pairs instead of key: value pairs

v0.8.3

Compare Source

v0.8.2: Fix missing sendRawTelemetryEvent function + Dependency updates

Compare Source

  • Fixes the sendRawTelemetryEvent function which was missing in the implementation, but defined in the .d.ts
  • Updates word-wrap and semver to address Dependabot security violations

v0.8.1: Better teardown + error handling

Compare Source

This release only contains bug fixes

  • Fixes a bug where we would cause infinite error loops in the sendErrorData function microsoft#158
  • Fixes a bug where we would not properly wait for the telemetry buffer to flush microsoft#155

v0.8.0: Better align telemetry reporters across desktop and web

Compare Source

Note: This release contains a breaking change to the typings.
The ability to log a raw Error object has been removed. You will now have to use sendTelemetryErrorEvent and break the error stack down into the properties you want due to the web app insights and 1DS library both not supporting this. We want the module to abstract the details away and offer a uniform experience across all platforms.

Also fixes a bug surrounding not logging events properly on shutdown.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Summary by CodeRabbit

  • Chores
    • Updated a telemetry-related dependency as part of routine maintenance.
    • Maintenance-only change: no user-facing UI, feature, or API changes.
    • No expected impact on functionality, performance, or behavior for end users.
    • No action required by end users; ensures dependencies remain current for stability and support.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 18, 2025

📝 Walkthrough

Walkthrough

The pull request updates the top-level dependency @vscode/extension-telemetry in package.json from ^0.7.7 to ^0.9.0. No other files, source code, API usage, control flow, error handling, exported/public declarations, or additional dependencies were changed.

Suggested reviewers

  • saltenasl

Pre-merge checks

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title accurately describes the main change: a dependency version bump of @vscode/extension-telemetry from ^0.7.7 to ^0.9.0.
Linked Issues check ✅ Passed PR addresses issue #192742 regarding shutdown delay by updating @vscode/extension-telemetry to ^0.9.0, which includes shutdown performance improvements in v0.8.5.
Out of Scope Changes check ✅ Passed Only package.json dependency updated; changes are scoped to the linked issue's objective of resolving shutdown delays.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 67c6bda and 55886e9.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build & Test
🔇 Additional comments (1)
package.json (1)

2492-2492: Review comment is incorrect. No breaking API change exists between v0.7.7 and v0.9.0.

Both versions support the same core telemetry APIs—sendTelemetryEvent() and sendTelemetryErrorEvent(). v0.8.0 does not exist in the official repository; releases begin at v0.9.x. The telemetry wrapper calling reporter.sendTelemetryEvent() is valid in both versions and will not cause runtime failures after upgrading to v0.9.0.

Likely an incorrect or invalid review comment.


Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot previously approved these changes Oct 18, 2025
@renovate renovate bot force-pushed the renovate/vscode-extension-telemetry-0.x branch from 6942d8b to 7123473 Compare October 20, 2025 16:17
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73%. Comparing base (b817a89) to head (55886e9).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #83   +/-   ##
=====================================
  Coverage     73%     73%           
=====================================
  Files        577     577           
  Lines      47663   47663           
  Branches    5597    5597           
=====================================
  Hits       34939   34939           
  Misses     10887   10887           
  Partials    1837    1837           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@renovate renovate bot force-pushed the renovate/vscode-extension-telemetry-0.x branch 5 times, most recently from 3a9b7ba to 7f50b10 Compare October 20, 2025 18:09
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6942d8b and 7f50b10.

📒 Files selected for processing (1)
  • package.json (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: CI
package.json

[error] 1-1: Dependency graph inconsistency detected by npm ci: lock file diverges from package.json. Consider running 'npm install' to synchronize.

🪛 GitHub Actions: Copilot Setup Steps
package.json

[warning] 1-1: EBADENGINE: Unsupported engine. Required node >=22.17.0, current node v22.15.1. Consider upgrading Node to satisfy engine requirements.

🔇 Additional comments (2)
package.json (2)

2169-2169: Good: telemetry update addresses shutdown behavior concerns.

The v0.8.4–v0.8.5 fixes for shutdown behavior and connection loss mentioned in release notes align with the linked issue #192742 about delayed process termination. The version bump is within reasonable semver bounds for a pre-1.0 package.


1-1: Review comment is incorrect.

The package.json contains no Node version requirement—its engines field specifies only "vscode": "^1.103.0". The CI workflow uses NODE_VERSION: 22.x, which is flexible and accepts any 22.x release. No mismatch exists.

Likely an incorrect or invalid review comment.

@renovate renovate bot force-pushed the renovate/vscode-extension-telemetry-0.x branch 3 times, most recently from 4011ae1 to 9d45c75 Compare October 21, 2025 11:08
@renovate renovate bot force-pushed the renovate/vscode-extension-telemetry-0.x branch from 9d45c75 to 73ef508 Compare October 21, 2025 13:32
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d45c75 and 73ef508.

📒 Files selected for processing (1)
  • package.json (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: CD
package.json

[warning] 1-1: Unsupported engine: current Node/v12+ (v22.15.1) does not satisfy required: node >=22.17.0 for @vscode/python-extension@1.0.6. Consider upgrading Node to at least 22.17.0.

🪛 GitHub Actions: CI
package.json

[warning] 1-1: EBADENGINE: Unsupported engine. The package '@vscode/python-extension@1.0.6' requires node >=22.17.0 (current: v22.15.1) and npm 10.9.2. Consider upgrading Node.js to satisfy engine requirements.

@renovate renovate bot force-pushed the renovate/vscode-extension-telemetry-0.x branch 7 times, most recently from 95841ca to c8c0bdf Compare October 23, 2025 09:07
@renovate renovate bot force-pushed the renovate/vscode-extension-telemetry-0.x branch 5 times, most recently from 9c168e5 to 3c4294f Compare November 3, 2025 20:59
@renovate renovate bot force-pushed the renovate/vscode-extension-telemetry-0.x branch 15 times, most recently from 1b335af to 2ac94d1 Compare November 5, 2025 08:30
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8ef19df and 2ac94d1.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json (1 hunks)

@renovate renovate bot force-pushed the renovate/vscode-extension-telemetry-0.x branch from 2ac94d1 to aa3817b Compare November 5, 2025 12:04
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2ac94d1 and aa3817b.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build & Package Extension

@renovate renovate bot force-pushed the renovate/vscode-extension-telemetry-0.x branch 3 times, most recently from 8b9019c to 67c6bda Compare November 6, 2025 09:22
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8479f28 and 67c6bda.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json (1 hunks)

"@lumino/widgets": "^2.4.0",
"@nteract/messaging": "^7.0.0",
"@vscode/extension-telemetry": "^0.7.7",
"@vscode/extension-telemetry": "^0.9.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🔴 Critical blocker: telemetry wrapper incompatible with v0.8.0+ API—fix required before merge.

Line 2492 updates @vscode/extension-telemetry to ^0.9.0, but v0.8.0 introduced a breaking change: raw Error logging was removed. The telemetry wrapper at src/platform/telemetry/index.ts still converts errors to properties and calls reporter.sendTelemetryEvent(), which no longer works. This will cause runtime failures when error events are sent.

Per the past review, sendTelemetryEventInternal() must detect error events and call reporter.sendTelemetryErrorEvent(eventNameSent, customProperties, measures) instead.

Action required: Confirm that src/platform/telemetry/index.ts has been updated to use the new API before merging, or defer this PR until the fix is in place.



---

🏁 Script executed:

```shell
#!/bin/bash
# Check if telemetry wrapper file exists and inspect error handling
fd -t f "index.ts" -p "*/telemetry/*" | head -20

Length of output: 100


🏁 Script executed:

#!/bin/bash
# Search for sendTelemetryErrorEvent and sendTelemetryEvent usage in telemetry files
rg -n "sendTelemetry(ErrorEvent|Event)" --type ts -A 2 -B 2 | head -60

Length of output: 5637


🏁 Script executed:

#!/bin/bash
# Check for error event handling patterns in telemetry code
rg -n "sendTelemetryEvent|sendTelemetryErrorEvent" --type ts -C 3 | head -80

Length of output: 7626


🏁 Script executed:

#!/bin/bash
# Look for the specific file mentioned in the review
find . -name "index.ts" -path "*/telemetry/*" -type f 2>/dev/null | xargs cat

Length of output: 13512



---

🏁 Script executed:

```shell
#!/bin/bash
# Check if sendTelemetryErrorEvent is used anywhere in the codebase
rg -n "sendTelemetryErrorEvent" --type ts

Length of output: 0


🔴 Critical blocker: telemetry wrapper incompatible with v0.8.0+ API—update required.

Line 2492 updates @vscode/extension-telemetry to ^0.9.0. Version 0.8.0 introduced a breaking change: raw Error logging was removed, requiring the sendTelemetryErrorEvent() API instead. The wrapper at src/platform/telemetry/index.ts still calls reporter.sendTelemetryEvent() when errors occur (line ~195), which fails with v0.9.0.

Fix: Update sendTelemetryEventInternal() to detect error events and call reporter.sendTelemetryErrorEvent(eventNameSent, customProperties, measures) instead of sendTelemetryEvent() when ex is defined.

🤖 Prompt for AI Agents
In package.json at line ~2492 and in src/platform/telemetry/index.ts around line
~195, the telemetry wrapper is incompatible with @vscode/extension-telemetry
v0.8.0+; update sendTelemetryEventInternal() so when an error object (ex) is
provided it calls reporter.sendTelemetryErrorEvent(eventNameSent,
customProperties, measures) instead of reporter.sendTelemetryEvent(...); detect
presence of ex, map customProperties/measures as before, and call
sendTelemetryErrorEvent with the same event name and payload; optionally
fallback to sendTelemetryEvent if sendTelemetryErrorEvent is not available to
preserve backward compatibility.

@renovate renovate bot force-pushed the renovate/vscode-extension-telemetry-0.x branch from 67c6bda to 55886e9 Compare November 6, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant