Skip to content

fix: add pip upgrading to deepnote toolkit installation #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 5, 2025
Merged

fix: add pip upgrading to deepnote toolkit installation #20

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b67da89
fix: add pip upgrading to deepnote toolkit installation
jankuca Oct 3, 2025
fb0ea81
chore: auto-format DEEPNOTE_KERNEL_IMPLEMENTATION.md
jankuca Oct 5, 2025
12fd559
chore: add info about pip upgrade to DEEPNOTE_KERNEL_IMPLEMENTATION.md
jankuca Oct 5, 2025
2018067
chore: update DEEPNOTE_KERNEL_IMPLEMENTATION.md to better explain ins…
jankuca Oct 5, 2025
0bd252c
chore: change markdown formatting tabwidth to 2 spaces
jankuca Oct 5, 2025
940b663
chore: reformat DEEPNOTE_KERNEL_IMPLEMENTATION.md with new md settings
jankuca Oct 5, 2025
41cb843
chore: fix md lint issues about fenced block
jankuca Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions src/kernels/deepnote/deepnoteToolkitInstaller.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,31 @@ export class DeepnoteToolkitInstaller implements IDeepnoteToolkitInstaller {
return undefined;
}

// Use undefined as resource to get full system environment (including git in PATH)
const venvProcessService = await this.processServiceFactory.create(undefined);

// Upgrade pip in the venv to the latest version
logger.info('Upgrading pip in venv to latest version...');
this.outputChannel.appendLine('Upgrading pip...');
const pipUpgradeResult = await venvProcessService.exec(
venvInterpreter.uri.fsPath,
['-m', 'pip', 'install', '--upgrade', 'pip'],
{ throwOnStdErr: false }
);

if (pipUpgradeResult.stdout) {
logger.info(`pip upgrade output: ${pipUpgradeResult.stdout}`);
}
if (pipUpgradeResult.stderr) {
logger.info(`pip upgrade stderr: ${pipUpgradeResult.stderr}`);
}

Cancellation.throwIfCanceled(token);

// Install deepnote-toolkit and ipykernel in venv
logger.info(`Installing deepnote-toolkit and ipykernel in venv from ${DEEPNOTE_TOOLKIT_WHEEL_URL}`);
this.outputChannel.appendLine('Installing deepnote-toolkit and ipykernel...');

// Use undefined as resource to get full system environment (including git in PATH)
const venvProcessService = await this.processServiceFactory.create(undefined);
const installResult = await venvProcessService.exec(
venvInterpreter.uri.fsPath,
[
Expand All @@ -174,7 +193,7 @@ export class DeepnoteToolkitInstaller implements IDeepnoteToolkitInstaller {
`deepnote-toolkit[server] @ ${DEEPNOTE_TOOLKIT_WHEEL_URL}`,
'ipykernel'
],
{ throwOnStdErr: true }
{ throwOnStdErr: false }
);

Cancellation.throwIfCanceled(token);
Expand Down