-
Notifications
You must be signed in to change notification settings - Fork 4
fix(deps): update dependency react-svg-pan-zoom to v3.13.1 #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Warning Rate limit exceeded@renovate[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 46 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDependency update to Suggested reviewers
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
=====================================
Coverage 73% 73%
=====================================
Files 577 577
Lines 47663 47663
Branches 5597 5597
=====================================
Hits 34939 34939
Misses 10887 10887
Partials 1837 1837 🚀 New features to boost your workflow:
|
c0cc58c to
6daee7b
Compare
a51c4c9 to
7058c31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "react-error-boundary": "^6.0.0", | ||
| "react-redux": "^7.1.1", | ||
| "react-svg-pan-zoom": "3.9.0", | ||
| "react-svg-pan-zoom": "3.13.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
The library upgraded to React 17 in v3.10, but the project specifies React ^16.5.2 (line 2215). This dependency spans 3.9.0 → 3.13.1, which likely breaks compatibility. Additionally, v3.13 removed deprecated defaultProps—confirm no impact on usage.
Run tests and verify React version before merge.
🏁 Script executed:
#!/bin/bash
# Find where react-svg-pan-zoom is actually used in the codebase
fd -e ts -e tsx -e js -e jsx -exec grep -l "react-svg-pan-zoom\|ReactSVGPanZoom" {} \;
# Check for any props usage patterns
rg -A 3 -B 3 "from.*react-svg-pan-zoom|import.*ReactSVGPanZoom" --type ts --type tsxLength of output: 247
🏁 Script executed:
#!/bin/bash
# Search for react-svg-pan-zoom imports and usage
rg "react-svg-pan-zoom|ReactSVGPanZoom" --type ts -A 2 -B 2
# Check React version in package.json
rg '"react":' package.jsonLength of output: 4252
🌐 Web query:
react-svg-pan-zoom 3.10 React version requirement
💡 Result:
react-svg-pan-zoom v3.10 migrated the library to React 17 (i.e., requires React 17). [1][2]
Sources:
- npm package changelog (react-svg-pan-zoom) — notes for v3.10: "Migrates to React 17...". [npm]. [1]
- Libraries.io / package changelog — v3.10: "Migrates to React 17 and Storybook 6...". [2]
react-svg-pan-zoom v3.10 requires React 17, but the project uses React ^16.5.2. The upgrade to 3.13.1 will break svgViewer.tsx, toolbar.tsx, and mainPanel.tsx which actively depend on this library.
Either downgrade to 3.9.x, upgrade React to 17+, or reject this PR.
🤖 Prompt for AI Agents
In package.json around line 2220, the bump of react-svg-pan-zoom to 3.13.1
introduces a React 17 requirement that breaks our codebase which uses React
^16.5.2; revert this change by pinning react-svg-pan-zoom to a 3.9.x release (or
other 3.10-compatible 16.x-safe version) or alternatively upgrade the project
React/deps to 17+ and update any typings/usages accordingly; after changing
package.json, run a fresh install, run unit/CI tests and verify svgViewer.tsx,
toolbar.tsx and mainPanel.tsx compile and behave (or update them for React 17)
before merging.
6cfd3ca to
ab4c27e
Compare
650f012 to
598b560
Compare
598b560 to
1a8e102
Compare
This PR contains the following updates:
3.9.0->3.13.1Release Notes
chrvadala/react-svg-pan-zoom (react-svg-pan-zoom)
v3.13.1Compare Source
react-svg-pan-zoom - 👀 A React component that adds pan and zoom features to SVG
v3.13.0Compare Source
react-svg-pan-zoom - 👀 A React component that adds pan and zoom features to SVG
v3.12.1Compare Source
react-svg-pan-zoom - 👀 A React component that adds pan and zoom features to SVG
v3.12.0Compare Source
react-svg-pan-zoom - 👀 A React component that adds pan and zoom features to SVG
v3.11.0: Release 3.11.0Compare Source
Release 3.11.0
v3.10.0: Release 3.10.0Compare Source
Release 3.10.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
Summary by CodeRabbit