Skip to content

fix: Disable backslash escapes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mfranczel
Copy link

@mfranczel mfranczel commented May 16, 2025

Part of PLA-3983

Todos

  • MIT compatible
  • Tests
  • Documentation
  • Updated CHANGES.rst

@mfranczel mfranczel force-pushed the michal/pla-3983-fix-compatibility-issues-between-pandas-sqlalchemy-and branch from 949bff5 to 4064d6e Compare May 21, 2025 17:47
@OlegWock
Copy link

Changes here doesn't seem to target specific sqlalchemy version, are they backward compatible with older versions of sqlalchemy we support?

@mfranczel
Copy link
Author

mfranczel commented May 22, 2025

@OlegWock It should be compatible with older sqlalchemy versions - issue with the new one was that 2.0 by default calls SHOW standard_conforming_strings which is not supported by redshift, causing it to error out. Disabling backslash escapes in the dialect tells sqlalchemy to skip it. So:

  • sqlalchemy < 2 doesn't call it altogether no matter what we set here
  • sqlalchemy >= 2 would call it by default, unless it's specified in dialect that it's not supported

@mfranczel mfranczel merged commit f194bd2 into main May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants