Github action to publish the package #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstastny
force-pushed
the
js/publish-github-package
branch
19 times, most recently
from
db9a2bc to
07e6e53
Compare
vire
reviewed
Mar 22, 2023
.github/workflows/publish.yaml
Outdated
| - run: yarn install | ||
| - run: yarn npm:prepublish | ||
| - name: Set the package name | ||
| run: npm pkg set --workspace packages/server name=@deepnote/sql-language-server |
There was a problem hiding this comment.
suggestion: I would maybe add a line that this does the renaming of original package.json name field :) it's not that super obvious but maybe not important as well...
There was a problem hiding this comment.
Sure. I can add comments (and was planning to). I assume by "line" you mean "comment", correct?
jstastny
force-pushed
the
js/publish-github-package
branch
from
07e6e53 to
690c386
Compare
jstastny
force-pushed
the
js/publish-github-package
branch
from
3aba010 to
48ce253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new github action "publish", which is triggered any time tag starting with
v(for examplev1.3.5) is pushed.The action then builds and publishes version according to the tag name. So for example for tag
v1.3.5, this action will publish1.3.5. The workflow expects the tag to follow semantic versioning -- internally it usesyarn version(from yarn classic -- because it is used by the upstream) and it fails on invalid / non-semantic versions.Given this is triggered by tag, the workflow does not push back the altered
package.jsonwith the bumped version.The package is pushed to GitHub package registry in this repository.