Skip to content

Conversation

@mfranczel
Copy link
Member

@mfranczel mfranczel commented Nov 6, 2025

Summary by CodeRabbit

  • Chores
    • Updated build and test infrastructure to use Python 3.11 instead of Python 3.9 across CI/CD workflows and local testing processes.

@mfranczel mfranczel self-assigned this Nov 6, 2025
@linear
Copy link

linear bot commented Nov 6, 2025

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 6, 2025

📝 Walkthrough

Walkthrough

Updated CI/CD workflows and test scripts to use Python 3.11 instead of 3.9. The .github/workflows/cd.yml now dynamically propagates the Python version through environment variables and Docker build arguments, replacing hard-coded version references. The bin/test-local script similarly defaults to Python 3.11. Changes maintain existing logic and control flow.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title clearly and specifically describes the main change: bumping Python version from 3.9 to 3.11 for jupyter-for-local across workflow and test scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 67a97b4 and be1abfc.

📒 Files selected for processing (2)
  • .github/workflows/cd.yml (2 hunks)
  • bin/test-local (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Build and push artifacts for Python 3.9
  • GitHub Check: Build and push artifacts for Python 3.13
  • GitHub Check: Build and push artifacts for Python 3.12
  • GitHub Check: Build and push artifacts for Python 3.11
  • GitHub Check: Build and push artifacts for Python 3.10
  • GitHub Check: Test - Python 3.12
  • GitHub Check: Test - Python 3.10
  • GitHub Check: Test - Python 3.11
  • GitHub Check: Test - Python 3.9
🔇 Additional comments (3)
bin/test-local (1)

18-18: Version bump applied correctly.

Default PYTHON_VERSION updated from "3.9" to "3.11" as intended.

.github/workflows/cd.yml (2)

23-23: Version bump applied correctly.

Workflow-level default updated to "3.11".


398-406: Dynamic version propagation implemented correctly.

The changes replace hard-coded "3.9" references with the variable, making the build more maintainable.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

📦 Python package built successfully!

  • Version: 1.1.1.dev5+f7abc6a
  • Wheel: deepnote_toolkit-1.1.1.dev5+f7abc6a-py3-none-any.whl
  • Install:
    pip install "deepnote-toolkit @ https://deepnote-staging-runtime-artifactory.s3.amazonaws.com/deepnote-toolkit-packages/1.1.1.dev5%2Bf7abc6a/deepnote_toolkit-1.1.1.dev5%2Bf7abc6a-py3-none-any.whl"

@mfranczel mfranczel requested a review from FilipPyrek November 6, 2025 16:55
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.39%. Comparing base (358138f) to head (e819d5b).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   76.94%   75.39%   -1.55%     
==========================================
  Files          99       99              
  Lines        5512     5625     +113     
  Branches      753      784      +31     
==========================================
  Hits         4241     4241              
- Misses       1271     1384     +113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coderabbitai[bot]
coderabbitai bot previously approved these changes Nov 6, 2025
@deepnote-bot
Copy link

deepnote-bot commented Nov 6, 2025

🚀 Review App Deployment Started

📝 Description 🌐 Link / Info
🌍 Review application ra-21
🔑 Sign-in URL Click to sign-in
📊 Application logs View logs
🔄 Actions Click to redeploy
🚀 ArgoCD deployment View deployment
Last deployed 2025-11-07 09:29:04 (UTC)
📜 Deployed commit c47eb74206aeb574189ed0bef14c2d7cbfaf190e
🛠️ Toolkit version f7abc6a

@mfranczel mfranczel marked this pull request as ready for review November 6, 2025 17:10
@mfranczel mfranczel requested a review from a team as a code owner November 6, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants