Skip to content

Conversation

@OlegWock
Copy link
Member

@OlegWock OlegWock commented Nov 6, 2025

Summary by CodeRabbit

  • Chores
    • Updated the deepnote-vegafusion dependency constraint to require version >=2.0.8 and <3. No other dependencies or application behavior were changed.

@linear
Copy link

linear bot commented Nov 6, 2025

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 6, 2025

📝 Walkthrough

Walkthrough

The deepnote-vegafusion dependency in pyproject.toml was changed from >=2.0.5,<3 to >=2.0.8,<3. The minimum required version increases from 2.0.5 to 2.0.8; the upper bound remains <3. No code, control flow, method signatures, or error handling were modified.

Sequence Diagram(s)

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title accurately describes the main change: updating the deepnote-vegafusion dependency constraint from >=2.0.5,<3 to >=2.0.8,<3.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 956e294 and d46531c.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-06T13:48:46.482Z
Learnt from: OlegWock
Repo: deepnote/deepnote-toolkit PR: 20
File: pyproject.toml:126-126
Timestamp: 2025-11-06T13:48:46.482Z
Learning: When using `poetry add` command, Poetry automatically formats version specifiers with parentheses (e.g., `(>=2.0.8,<3)`). This is valid PEP 508 syntax and tool-generated behavior, not a user error.

Applied to files:

  • pyproject.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
  • GitHub Check: Build and push artifacts for Python 3.12
  • GitHub Check: Build and push artifacts for Python 3.13
  • GitHub Check: Build and push artifacts for Python 3.9
  • GitHub Check: Build and push artifacts for Python 3.10
  • GitHub Check: Build and push artifacts for Python 3.11
  • GitHub Check: Test - Python 3.12
  • GitHub Check: Test - Python 3.9
  • GitHub Check: Test - Python 3.10
  • GitHub Check: Test - Python 3.11
  • GitHub Check: Test - Python 3.13
  • GitHub Check: Typecheck - 3.13
  • GitHub Check: Typecheck - 3.12
  • GitHub Check: Typecheck - 3.9
🔇 Additional comments (1)
pyproject.toml (1)

126-126: Formatting is now consistent; verify the version bump rationale.

The dependency formatting is correct (no parentheses, matching other entries). However, the jump from 2.0.5 to 2.0.8 spans three patch versions. Clarify in the commit message why this specific version is required—is it for the stacked column chart feature suggested by the branch name, or are there security/compatibility fixes in 2.0.6–2.0.8 that necessitate the bump?


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

📦 Python package built successfully!

  • Version: 1.1.1.dev4+8d82c7f
  • Wheel: deepnote_toolkit-1.1.1.dev4+8d82c7f-py3-none-any.whl
  • Install:
    pip install "deepnote-toolkit @ https://deepnote-staging-runtime-artifactory.s3.amazonaws.com/deepnote-toolkit-packages/1.1.1.dev4%2B8d82c7f/deepnote_toolkit-1.1.1.dev4%2B8d82c7f-py3-none-any.whl"

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 67a97b4 and a97939b.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
🔇 Additional comments (1)
pyproject.toml (1)

126-126: Justify the version bump from 2.0.5 to 2.0.8.

The minimum constraint was raised by 3 minor versions. Verify this is necessary (e.g., bug fixes, feature requirement for temporal x-axis support noted in the branch name) and ensure all dependent code is compatible.

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.94%. Comparing base (5eddb88) to head (d46531c).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   76.94%   76.94%           
=======================================
  Files          99       99           
  Lines        5512     5512           
  Branches      753      753           
=======================================
  Hits         4241     4241           
  Misses       1271     1271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepnote-bot
Copy link

deepnote-bot commented Nov 6, 2025

🚀 Review App Deployment Started

📝 Description 🌐 Link / Info
🌍 Review application ra-20
🔑 Sign-in URL Click to sign-in
📊 Application logs View logs
🔄 Actions Click to redeploy
🚀 ArgoCD deployment View deployment
Last deployed 2025-11-07 07:31:32 (UTC)
📜 Deployed commit c47eb74206aeb574189ed0bef14c2d7cbfaf190e
🛠️ Toolkit version 8d82c7f

@OlegWock OlegWock marked this pull request as ready for review November 6, 2025 14:04
@OlegWock OlegWock requested a review from a team as a code owner November 6, 2025 14:04
@OlegWock OlegWock requested a review from m1so November 6, 2025 21:42
@OlegWock OlegWock merged commit 358138f into main Nov 7, 2025
34 checks passed
@OlegWock OlegWock deleted the oleh/blu-5089-stacked-column-chart-with-temporal-x-axis-and-daily-time branch November 7, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants