Skip to content

Conversation

@Yggdrasill501
Copy link
Contributor

@Yggdrasill501 Yggdrasill501 commented Nov 2, 2025

Summary by CodeRabbit

  • Documentation
    • Restructured and reorganized documentation layout with updated visual presentation including new cover image
    • Reorganized sections for improved clarity: installation, features, architecture, usage, development, and Docker guidance
    • Simplified installation instructions with clear command examples
    • Added Architecture section explaining kernel vs server bundle differences
    • Enhanced Docker usage documentation with local development and hot-reload guidance
    • Updated usage examples and security notes

@linear
Copy link

linear bot commented Nov 2, 2025

@Yggdrasill501 Yggdrasill501 self-assigned this Nov 2, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 2, 2025

📝 Walkthrough

Walkthrough

This PR completely restructures the README.md documentation. Content reorganizes from a feature-oriented layout to an installation-first approach. Major changes include: replacing headers with centered HTML and cover image, reorganizing sections (installation, features, architecture, usage, development, Docker, contributing, support), simplifying installation steps with pip commands, introducing an explicit "Architecture" section describing kernel/server bundles, updating CLI usage examples, pivoting from nox/mise/docker testing workflows to Docker-centric development guidance, and consolidating deployment/test automation into three defined Dockerfiles.

Possibly related PRs

Pre-merge checks

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The pull request title states "docs: update cover image in readme," which references a real change (the summary notes a cover image was added to the header). However, the raw summary reveals the changes are far more extensive: a complete rewrite and reorganization of the entire README structure, including new sections (Architecture), restructured installation instructions, overhauled usage guidance, and Docker-centric workflow updates. The title focuses on a minor visual element while obscuring the substantial documentation restructuring that is the primary change, which would mislead a teammate scanning the history about the true scope of this PR. Consider retitling to reflect the main objective, such as "docs: restructure readme with updated architecture and setup guidance" or similar, to accurately capture the comprehensive documentation changes beyond the visual update. The current title undersells the actual work performed.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f5a2f7d and 1755e68.

⛔ Files ignored due to path filters (1)
  • assets/deepnote-toolkit-cover-image.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • README.md (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md

2-2: First line in a file should be a top-level heading

(MD041, first-line-heading, first-line-h1)


16-16: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)


35-35: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


41-41: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


47-47: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)

🔇 Additional comments (1)
README.md (1)

4-4: Asset verified.

The cover image exists at ./assets/deepnote-toolkit-cover-image.png. No action needed.

# Deepnote Toolkit

#### Option 2: Manual setup
The Deepnote Toolkit is a Python package that powers the [Deepnote notebook environment](https://github.com/deepnote/deepnote/). It provides the essential functionality that runs in user workspaces, enabling interactive data science workflows with SQL, visualizations, and integrations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove trailing whitespace.

Line 16 has trailing whitespace.

-The Deepnote Toolkit is a Python package that powers the [Deepnote notebook environment](https://github.com/deepnote/deepnote/). It provides the essential functionality that runs in user workspaces, enabling interactive data science workflows with SQL, visualizations, and integrations. 
+The Deepnote Toolkit is a Python package that powers the [Deepnote notebook environment](https://github.com/deepnote/deepnote/). It provides the essential functionality that runs in user workspaces, enabling interactive data science workflows with SQL, visualizations, and integrations.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
The Deepnote Toolkit is a Python package that powers the [Deepnote notebook environment](https://github.com/deepnote/deepnote/). It provides the essential functionality that runs in user workspaces, enabling interactive data science workflows with SQL, visualizations, and integrations.
The Deepnote Toolkit is a Python package that powers the [Deepnote notebook environment](https://github.com/deepnote/deepnote/). It provides the essential functionality that runs in user workspaces, enabling interactive data science workflows with SQL, visualizations, and integrations.
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

16-16: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

🤖 Prompt for AI Agents
In README.md around line 16, remove the trailing whitespace at the end of that
line; open the file, delete any extra spaces or tabs after the sentence on line
16 (and optionally run a trim-whitespace linter or editor command to remove
trailing whitespace across the file), then save the file.

```bash
$ poetry self add 'poethepoet[poetry_plugin]'
```
### Core capabilities
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add blank lines before subheadings.

Subheadings require blank lines above them per markdown style (MD022).

 ## Features
 
+
 ### Core capabilities
 - **SQL execution engine**: Multi-database SQL support with connection management, query templating via Jinja2, intelligent caching, and query chaining with CTE generation
 - **Interactive visualizations**: Vega-Lite charts with VegaFusion optimization, multi-layer support, and interactive selections
 - **Data processing**: Enhanced DataFrame utilities, data sanitization, and DuckDB in-memory analytics
 - **Jupyter integration**: Custom IPython kernel with scientific computing libraries (pandas, numpy, etc.)
 
+
 ### Developer tools
 - **CLI interface**: Command-line tools for server management and configuration
 - **Streamlit support**: Auto-reload development workflow for Streamlit applications
 - **Language server protocol**: Code intelligence and autocompletion support
 - **Runtime initialization**: Session persistence, environment variable management, and post-start hooks
 
+
 ### Infrastructure
 - **Git integration**: SSH/HTTPS authentication for repository access
 - **SSH tunneling**: Secure database connections through SSH tunnels
 - **Metrics collection**: Prometheus metrics for monitoring and observability
 - **Feature flags**: Dynamic feature toggling support

Also applies to: 41-41, 47-47

🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

35-35: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)

🤖 Prompt for AI Agents
In README.md around lines 35, 41, and 47, the subheadings lack the required
blank line above them (MD022); fix by inserting a single blank line immediately
before each subheading line so each "###" header is preceded by an empty line,
then run a markdown linter to confirm MD022 passes.

## Contributing

- `builder.Dockerfile`: Creates Python package bundles for different versions (3.9-3.12), generates kernel and server bundles, and packages the toolkit for distribution using Poetry.
See [CONTRIBUTING.md](CONTRIBUTING.md) for development setup, coding standards, and contribution guidelines.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify referenced documentation files exist.

The README links to CONTRIBUTING.md, LICENSE, and SECURITY.md. Confirm these files are present in the repository.

Also applies to: 167-167, 173-173


🏁 Script executed:

#!/bin/bash
# Verify supporting documentation files
for file in CONTRIBUTING.md LICENSE SECURITY.md; do
  if [ -f "$file" ]; then
    echo "$file exists"
  else
    echo "$file missing"
  fi
done

Length of output: 63


Create missing CONTRIBUTING.md file.

README.md references CONTRIBUTING.md (line 163), but the file does not exist. Create this file with development setup, coding standards, and contribution guidelines.

🤖 Prompt for AI Agents
In README.md around line 163, the document links to CONTRIBUTING.md which is
missing; create a CONTRIBUTING.md file at the repository root containing the
project's development setup (prerequisites, installation, running locally,
testing), coding standards (style guide, linting, commit message format), and
contribution guidelines (branching model, PR template checklist, review process,
issue reporting and template, and code of conduct), and add a brief note in
README.md if desired pointing to the new file; ensure the CONTRIBUTING.md is
clear, concise, and uses Markdown headings for each section.

@Yggdrasill501 Yggdrasill501 deleted the filipzitny/mar-342-update-cover-images-for-oss-repos branch November 2, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants