Skip to content

Conversation

@FilipPyrek
Copy link
Member

@FilipPyrek FilipPyrek commented Oct 31, 2025

Summary by CodeRabbit

Release Notes

  • New Features

    • Added support for Python 3.13
  • Bug Fixes

    • Fixed histogram extraction compatibility with NumPy 2.2+
  • Chores

    • Upgraded Java runtime from version 11 to 17
    • Updated dependencies for Python 3.13 compatibility
    • Updated documentation reflecting current supported versions

@linear
Copy link

linear bot commented Oct 31, 2025

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2025

Note

Reviews paused

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
📝 Walkthrough

Walkthrough

This PR adds Python 3.13 support throughout the project and upgrades Java from version 11 to version 17. Changes include updating CI/CD workflows, documentation, configuration files (pyproject.toml, noxfile.py, .mise.toml), and Docker build environments. Additionally, error handling in deepnote_toolkit/ocelots/pandas/analyze.py is updated to catch ValueError instead of IndexError for NumPy 2.2+ compatibility, specifically handling the "Too many bins for data range" scenario.

Possibly related PRs

  • #193: Modifies the same CI/test tooling files (noxfile.py, .github workflows, .mise.toml, README.md, pyproject.toml) for Python version matrices and test setup changes.

Suggested reviewers

  • m1so
  • jamesbhobbs
  • hc2p

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "feat: python 3.13 support" directly aligns with the primary objective of the changeset. Python 3.13 support is added across multiple critical files including noxfile.py, pyproject.toml, .cursorrules, CLAUDE.md, and CI/CD workflows. While the PR also includes secondary changes—Java 17 upgrades and a NumPy 2.2+ compatibility fix—the Python 3.13 support constitutes the main initiative. The title is clear, specific, and concise, accurately highlighting the most significant change without claiming to cover every modification (as expected per guidelines).

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

📦 Python package built successfully!

  • Version: 1.0.0.dev17+abf85ce
  • Wheel: deepnote_toolkit-1.0.0.dev17+abf85ce-py3-none-any.whl
  • Install:
    pip install "deepnote-toolkit @ https://deepnote-staging-runtime-artifactory.s3.amazonaws.com/deepnote-toolkit-packages/1.0.0.dev17%2Babf85ce/deepnote_toolkit-1.0.0.dev17%2Babf85ce-py3-none-any.whl"

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.12%. Comparing base (059d347) to head (b0ca5c6).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   76.60%   75.12%   -1.48%     
==========================================
  Files          99       99              
  Lines        5476     5601     +125     
  Branches      748      782      +34     
==========================================
+ Hits         4195     4208      +13     
- Misses       1281     1393     +112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FilipPyrek
Copy link
Member Author

@coderabbitai pause

@FilipPyrek FilipPyrek force-pushed the fpyrek/grn-4947-support-python-313 branch from 35fc1c5 to 2a1a117 Compare October 31, 2025 11:23
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2025

✅ Actions performed

Reviews paused.

@deepnote-bot
Copy link

deepnote-bot commented Oct 31, 2025

🚀 Review App Deployment Started

📝 Description 🌐 Link / Info
🌍 Review application ra-10
🔑 Sign-in URL Click to sign-in
📊 Application logs View logs
🔄 Actions Click to redeploy
🚀 ArgoCD deployment View deployment
Last deployed 2025-11-03 15:19:07 (UTC)
📜 Deployed commit 6c8cbf514e3a51d7a9256742fe04d1ce36c9e2e3
🛠️ Toolkit version abf85ce

@FilipPyrek FilipPyrek force-pushed the fpyrek/grn-4947-support-python-313 branch 10 times, most recently from 4507cbc to d433da8 Compare November 3, 2025 09:56
FilipPyrek and others added 6 commits November 3, 2025 14:06
Co-authored-by: mfranczel <mfranczel@users.noreply.github.com>
This update introduces a new function, _get_type_name, to ensure that the type name for NumPy's bool_ is consistently returned as 'bool_' across different Python versions, particularly for Python 3.13. The variable type retrieval in _get_variable_dict_entry has been updated to use this new function.
@FilipPyrek FilipPyrek force-pushed the fpyrek/grn-4947-support-python-313 branch from d433da8 to 72c9fe1 Compare November 3, 2025 13:06
@FilipPyrek FilipPyrek force-pushed the fpyrek/grn-4947-support-python-313 branch from 3bc1602 to b0ca5c6 Compare November 3, 2025 14:38
@FilipPyrek FilipPyrek requested a review from mfranczel November 3, 2025 14:44
@FilipPyrek FilipPyrek marked this pull request as ready for review November 3, 2025 14:44
@FilipPyrek FilipPyrek requested a review from a team as a code owner November 3, 2025 14:44
@FilipPyrek FilipPyrek merged commit 67a97b4 into main Nov 3, 2025
33 of 34 checks passed
@FilipPyrek FilipPyrek deleted the fpyrek/grn-4947-support-python-313 branch November 3, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants