make show-avatar default for everyone (fixes daattali#715)

deepmtch · Aug 31, 2020 · 99223b0 · 99223b0
1 parent 289bf27
commit 99223b0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ One of the major changes in this version is that a lot of time was spent on reth
 - **BREAKING CHANGE** Removed YAML option `use-site-title` (you can now specify the exact title using `share-title`)
 - **BREAKING CHANGE** Removed undocumented YAML options `meta-title` and `meta-description`
 - **BREAKING CHANGE** Removed `link-tags` config parameter because it wasn't necessary. If you use tags, there will be a tags page created; if you don't use tags there is no tags page.
+- **BREAKING CHANGE** The YAML setting `show-avatar` is now true by default. This has always been the case for GitHub Pages users, but not for `remote_theme` users. For consistency, it's now the default for everyone. (#715)
 - Added `share-title` YAML option to give control over the search engine/social media title
 - Added `before-content` and `after-content` YAML options that allow you to add some common HTML before the main content of a page (below the title) or after the main content (above the footer). Works in a similar way to `footer-extra`.
 - Added `head-extra` YAML option which i s similar to `footer-extra` but is used to include custom HTML code in a page's `<head>` tag

diff --git a/_config.yml b/_config.yml
@@ -192,13 +192,11 @@ defaults:
       layout: "post"
       comments: true  # add comments to all blog posts
       social-share: true # add social media sharing buttons to all blog posts
-      readtime: false # add estimated reading time on all blog posts
   -
     scope:
-      path: "" # all files
+      path: "" # any file that's not a post will be a "page" layout by default
     values:
       layout: "page"
-      show-avatar: true
 
 # Exclude these files from production site
 exclude:

diff --git a/_includes/nav.html b/_includes/nav.html
@@ -33,7 +33,7 @@
     </ul>
   </div>
 
-  {% if site.avatar and (layout.show-avatar or page.show-avatar) %}
+  {% if site.avatar and page.show-avatar != false %}
     <div class="avatar-container">
       <div class="avatar-img-border">
         <a href="{{ '' | absolute_url }}">