fix(lammps): register Kokkos plugin styles - #5988
Conversation
Backport conda-forge/deepmd-kit-feedstock patch 0004 at d02138263b0b30629fe28c68c8bcecc2b8644513, with the new Kokkos plugin registrations attributed to Tiancheng Li. Agent: ChatGPT Model: GPT-5.6 Sol
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe plugin now includes Kokkos pair implementations, defines host and device factories, and registers Kokkos aliases for the ChangesKokkos pair-style integration
Estimated code review effort: 3 (Moderate) | ~15 minutes Merge Risk: ⚪ Minimal · up to This localized change registers the listed Kokkos plugin styles without any identified merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5988 +/- ##
==========================================
- Coverage 79.10% 78.84% -0.26%
==========================================
Files 1105 1105
Lines 130981 130979 -2
Branches 4771 4771
==========================================
- Hits 103609 103273 -336
- Misses 25686 26022 +336
+ Partials 1686 1684 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
OutisLi
left a comment
There was a problem hiding this comment.
The registration mapping itself looks correct, but this PR has runtime/build dependencies that should be explicit before merge. The upstream workflows never enable DEEPMD_LAMMPS_KOKKOS, so the new #ifdef LMP_KOKKOS block is not compiled there. The successful feedstock validation applied patches 0002, 0004, and 0005 together: #5987 supplies compatibility with the documented stable_22Jul2025 API, while #5989 removes the duplicate Kokkos runtime that its own description notes can corrupt shutdown when the plugin unloads. Please ensure the corrected #5987 and #5989 are merged before #5988 (or stack this PR on them), and validate an enabled Kokkos-plugin build plus plugin list; otherwise the aliases become discoverable while the corresponding plugin path remains known-unsafe and the upstream green checks do not exercise it.
Summary
Backport
0004-register-lammps-kokkos-plugin-styles.patchfromconda-forge/deepmd-kit-feedstock@d02138263b0b30629fe28c68c8bcecc2b8644513.Runtime LAMMPS plugins do not consume the
PairStyledeclarations used by the built-in package machinery, so explicitly register:deepmd/kkdeepmd/kk/devicedeepmd/kk/hostdpa4spin/kkdpa4spin/kk/devicedpa4spin/kk/hostThe newly registered Kokkos plugin styles are attributed to Tiancheng Li via
plugin.author.Validation
Agent: ChatGPT
Model: GPT-5.6 Sol
Summary by CodeRabbit