Skip to content

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Jan 5, 2026

Summary by CodeRabbit

  • Documentation

    • Updated installation and contributor guides to reference the master development flow and revised download/setup instructions.
    • Clarified contributor workflow to create and use new branches instead of working directly on the old development branch.
  • Chores

    • CI/CD workflows and deployment now target the master branch for pushes; Pages deployment triggers on master.
    • Removed obsolete automation/autoupdate settings and explicit branch targets from config.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings January 5, 2026 06:23
@github-actions github-actions bot added the Docs label Jan 5, 2026
@njzjz njzjz added the breaking change Breaking changes that should notify users. label Jan 5, 2026
@njzjz njzjz requested a review from wanghan-iapcm January 5, 2026 06:23
@OutisLi
Copy link
Collaborator

OutisLi commented Jan 5, 2026

I think the main branch name is more suitable than master

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR transitions the DeePMD-kit repository from a two-branch development model (master for stable releases, devel for development) to a single-branch model where master serves as the primary development branch. This is a breaking change that updates all references to the devel branch across documentation, workflows, and configuration files.

  • Updated documentation to reflect that master is now the development branch
  • Changed GitHub Actions workflows to trigger on master instead of devel
  • Removed the two-branch overview from CONTRIBUTING.md and updated contribution instructions

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
doc/install/install-from-source.md Updated to reference master as the development version instead of devel
doc/install/easy-install-dev.md Changed all references from devel to master for Docker tags, download links, and branch documentation
CONTRIBUTING.md Removed two-branch overview section and updated contribution workflow to use master branch and new branch creation pattern
.pre-commit-config.yaml Removed autoupdate_branch: devel configuration
.github/workflows/todo.yml Changed workflow trigger from devel to master branch
.github/workflows/build_wheel.yml Updated GitHub Pages deployment condition to check for master branch
.github/dependabot.yml Removed target-branch: "devel" settings for both github-actions and pip ecosystems

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 5, 2026

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

Update branch references from devel to master across CI workflows, Dependabot, pre-commit config, contributor guide, and installation docs; remove explicit devel target-branch/autoupdate entries.

Changes

Cohort / File(s) Summary
GitHub Actions workflows
.github/workflows/build_wheel.yml, .github/workflows/todo.yml
Trigger branch filters changed from devel to master (deploy and CI steps now run on pushes to master).
Dependabot & pre-commit config
.github/dependabot.yml, .pre-commit-config.yaml
Removed explicit target-branch: devel entries and deleted CI autoupdate autoupdate_branch: devel lines.
Contribution guidelines
CONTRIBUTING.md
Replaced devel references with master; revised fork/branch/merge/push instructions to use creating and working on new branches rather than committing to devel.
Installation docs
doc/install/easy-install-dev.md, doc/install/install-from-source.md
Updated docs and example commands/URLs/docker tags to reference master (development artifacts and downloads now point to master).

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • wanghan-iapcm

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main objective of the changeset: preparing to deprecate the devel branch by redirecting workflows, documentation, and configurations from devel to master.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.15%. Comparing base (b98f6c5) to head (88c2fc8).
⚠️ Report is 1 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #5122   +/-   ##
=======================================
  Coverage   82.15%   82.15%           
=======================================
  Files         709      709           
  Lines       72468    72467    -1     
  Branches     3616     3615    -1     
=======================================
+ Hits        59535    59537    +2     
+ Misses      11769    11768    -1     
+ Partials     1164     1162    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Jinzhe Zeng <njzjz@qq.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Fix all issues with AI Agents 🤖
In @doc/install/easy-install-dev.md:
- Line 29: The documentation currently links to pre-compiled C library artifacts
without any verification guidance; update the doc/install/easy-install-dev.md
entries that reference the pre-compiled C library (the "pre-compiled C library"
link and the nightly.link URL) to require and demonstrate checksum or signature
verification: advise publishing or linking to versioned release artifacts from a
trusted channel, add SHA256 (or better) checksum values and an example
verification command (or a GPG signature + verification flow) for the tarball,
and include a short note telling users to verify the checksum/signature before
extraction and installation.
- Line 29: Replace the vague link anchor text "here" in the sentence that points
to
https://nightly.link/deepmodeling/deepmd-kit/workflows/package_c/master/libdeepmd_c-0-libdeepmd_c.tar.gz.zip
with a descriptive label such as "pre-compiled libdeepmd_c archive" (or
"pre-compiled C library archive") in doc/install/easy-install-dev.md so the link
text conveys its destination instead of using "here".
📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0a3983 and 88c2fc8.

📒 Files selected for processing (1)
  • doc/install/easy-install-dev.md
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-12T13:40:14.334Z
Learnt from: CR
Repo: deepmodeling/deepmd-kit PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-12T13:40:14.334Z
Learning: Always install backend dependencies (TensorFlow/PyTorch) before building C++ components

Applied to files:

  • doc/install/easy-install-dev.md
🪛 markdownlint-cli2 (0.18.1)
doc/install/easy-install-dev.md

29-29: Link text should be descriptive

(MD059, descriptive-link-text)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (28)
  • GitHub Check: Analyze (c-cpp)
  • GitHub Check: Analyze (python)
  • GitHub Check: Build wheels for cp311-macosx_x86_64
  • GitHub Check: Build wheels for cp310-manylinux_aarch64
  • GitHub Check: Build wheels for cp311-macosx_arm64
  • GitHub Check: Build wheels for cp311-win_amd64
  • GitHub Check: Test Python (4, 3.13)
  • GitHub Check: Build wheels for cp311-manylinux_x86_64
  • GitHub Check: Build C++ (rocm, rocm)
  • GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
  • GitHub Check: Build C++ (clang, clang)
  • GitHub Check: Build C++ (cpu, cpu)
  • GitHub Check: Test Python (4, 3.10)
  • GitHub Check: Test Python (2, 3.13)
  • GitHub Check: Test Python (5, 3.13)
  • GitHub Check: Build C++ (cuda120, cuda)
  • GitHub Check: Test Python (5, 3.10)
  • GitHub Check: Test Python (2, 3.10)
  • GitHub Check: Test Python (3, 3.13)
  • GitHub Check: Test Python (6, 3.13)
  • GitHub Check: Test Python (1, 3.10)
  • GitHub Check: Test Python (1, 3.13)
  • GitHub Check: Test Python (3, 3.10)
  • GitHub Check: Test Python (6, 3.10)
  • GitHub Check: Test C++ (true, true, true, false)
  • GitHub Check: Test C++ (false, true, true, false)
  • GitHub Check: Test C++ (true, false, false, true)
  • GitHub Check: Test C++ (false, false, false, true)
🔇 Additional comments (1)
doc/install/easy-install-dev.md (1)

3-3: Branch reference updates are consistent and align with PR objective.

The changes from devel to master across the documentation, Docker tag, and artifact download paths are coherent and directly support the branch deprecation goal.

Also applies to: 9-9, 12-12, 32-32

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Jan 6, 2026
Merged via the queue into deepmodeling:devel with commit fe1662d Jan 6, 2026
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Breaking changes that should notify users. Docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants