cc: refactor DataModifier for multiple-backend framework #3148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #3148 +/- ##
==========================================
- Coverage 76.26% 76.23% -0.03%
==========================================
Files 272 274 +2
Lines 25537 25570 +33
Branches 1583 1587 +4
==========================================
+ Hits 19475 19494 +19
- Misses 5135 5147 +12
- Partials 927 929 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| assert(output_f.dims() == 2 && "dim of output tensor should be 2"); | ||
| assert(output_v.dims() == 2 && "dim of output tensor should be 2"); | ||
| assert(output_av.dims() == 2 && "dim of output tensor should be 2"); | ||
| int nframes = output_f.dim_size(0); |
Check notice
Code scanning / CodeQL
Unused local variable
| assert(output_v.dims() == 2 && "dim of output tensor should be 2"); | ||
| assert(output_av.dims() == 2 && "dim of output tensor should be 2"); | ||
| int nframes = output_f.dim_size(0); | ||
| int natoms = output_f.dim_size(1) / 3; |
Check notice
Code scanning / CodeQL
Unused local variable
| const InputNlist& lmp_list) { | ||
| // firstly do selection | ||
| int nall = datype_.size(); | ||
| int nloc = nall - nghost; |
Check notice
Code scanning / CodeQL
Unused local variable
| // sort atoms | ||
| AtomMap atommap(datype_real.begin(), datype_real.begin() + nloc_real); | ||
| assert(nloc_real == atommap.get_type().size()); | ||
| const std::vector<int>& sort_fwd_map(atommap.get_fwd_map()); |
Check notice
Code scanning / CodeQL
Unused local variable
wanghan-iapcm
requested review from
CaRoLZhangxy
and removed request for
CaRoLZhangxy
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
for more information, see https://pre-commit.ci
wanghan-iapcm
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3119