cc: merge DeepPotBase and DeepTensor member functions
#3145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #3145 +/- ##
==========================================
- Coverage 76.22% 76.05% -0.18%
==========================================
Files 276 276
Lines 25631 25584 -47
Branches 1591 1591
==========================================
- Hits 19538 19458 -80
- Misses 5162 5202 +40
+ Partials 931 924 -7 ☔ View full report in Codecov by Sentry. |
njzjz
changed the title
DeepPotBase members functionsDeepPotBase member functions
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz
changed the title
DeepPotBase member functionsDeepPotBase and DeepTensor member functions
Collaborator
|
Shouldn't we change the compute method of XXXTF class as private methods ? |
Member
Author
Meaningful |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 18 member functions from
DeepPotBaseand 4 member functions fromDeepTensor.