Skip to content

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Dec 5, 2023

Resolves #3027.

@njzjz njzjz added the breaking change Breaking changes that should notify users. label Dec 5, 2023
@codecov
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea45295) 75.73% compared to head (744ddd0) 75.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3036      +/-   ##
==========================================
- Coverage   75.73%   75.73%   -0.01%     
==========================================
  Files         245      245              
  Lines       24686    24685       -1     
  Branches     1591     1595       +4     
==========================================
- Hits        18697    18696       -1     
  Misses       5054     5054              
  Partials      935      935              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scale factor in the atomic force deviation should also be removed.

std_f_all[tagrecv[dd] - 1] =
stdfrecv[dd] * scale[1][1] * force_unit_cvt_factor;

njzjz and others added 2 commits December 5, 2023 00:54
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@wanghan-iapcm wanghan-iapcm merged commit 3c54949 into deepmodeling:devel Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Breaking changes that should notify users. Docs LAMMPS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants