Skip to content

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Nov 20, 2023

Recently I contributed Horovod to conda-forge at conda-forge/staged-recipes#24472. I have tested it with DeePMD-kit. Now the Conda-forge channel has all the features in our deepmodeling channel and even more available platforms.

I wonder if we should recommend Conda-forge in favor of our DeepModeling channel and use it for the offline installer. In 2019, Conda-forge lacked support for TensorFlow, so we hosted and built our own channel against the Anaconda channel. But now Conda-forge has become a mature channel and has better support for TensorFlow than the Anaconda channel.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@github-actions github-actions bot added the Docs label Nov 20, 2023
@njzjz njzjz requested a review from wanghan-iapcm November 20, 2023 21:15
@codecov
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a342e94) 26.93% compared to head (57f1261) 75.72%.

Additional details and impacted files
@@             Coverage Diff             @@
##            devel    #3001       +/-   ##
===========================================
+ Coverage   26.93%   75.72%   +48.79%     
===========================================
  Files         243      245        +2     
  Lines       24552    24676      +124     
  Branches     1591     1591               
===========================================
+ Hits         6613    18687    +12074     
+ Misses      17230     5054    -12176     
- Partials      709      935      +226     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Jinzhe, I agree with you.

@wanghan-iapcm wanghan-iapcm merged commit 66259b1 into deepmodeling:devel Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants