-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add and run pre-commit to format codes #2279
Conversation
@wanghan-iapcm It should be discussed what variant of the Clang format we prefer. Clang documentation provides a lot of styles (default is |
Let me check |
|
Codecov ReportBase: 75.27% // Head: 74.58% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## devel #2279 +/- ##
==========================================
- Coverage 75.27% 74.58% -0.69%
==========================================
Files 217 217
Lines 21109 21494 +385
Branches 1479 1563 +84
==========================================
+ Hits 15889 16031 +142
- Misses 4281 4447 +166
- Partials 939 1016 +77
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Not required. There was a similar PR in scikit-learn/scikit-learn#18948, and scikit-learn/scikit-learn#20301 provides an automatic way to fix conflicts. |
Prepare #2279. - Fix some C++ headers which didn't include the std library. - Add Clang-format config file. - Remove the old lint Python action.
for more information, see https://pre-commit.ci
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Including Black for Python, Clang format for C++, and others for Shell, CMake, JSON, and CSS.