Refactor hsolver remove psi dimensions #4622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue
#4404
What's changed?
psidimensions (by calls to member funcions) has been removed.DiagoDavidhas been replaced by local variables where needed.Unit Tests and/or Case Tests for my changes
Any changes of core modules?
psi.get_k_first()logicThe
psi.get_k_first()function is no longer needed as thek_first=falsebranch does not contribute to the solution of the Kohn-Sham equations. Remove the associated code to streamline the solver.Pending further work
psi.get_ngk(0)andpsi.get_pointer()are still referenced insideDiagoDavid, to construct basis set. They need to be replaced by pointers to data field.