Fix xarray compatibility issues and improve empty dataset handling#106
Open
femiomitusa wants to merge 2 commits intodeeplycloudy:masterfrom
Open
Fix xarray compatibility issues and improve empty dataset handling#106femiomitusa wants to merge 2 commits intodeeplycloudy:masterfrom
femiomitusa wants to merge 2 commits intodeeplycloudy:masterfrom
Conversation
femiomitusa
commented
Jan 29, 2026
femiomitusa
commented
- Fix datetime extraction from xarray DataArray using .item() method (xarray datetime accessor now returns DataArrays, not scalars)
- Replace deprecated Dataset.dims[] with Dataset.sizes[] for dimension lengths to avoid FutureWarning in xarray >= 2024.10
- Add missing datetime import in mimic_lma.py
- Handle empty datasets gracefully in get_lutevents() by returning early with an empty lutevent_id dimension
- Use assert_allclose instead of assert_equal for floating point comparisons in test_event_lut.py to account for precision limits
- Fix datetime extraction from xarray DataArray using .item() method (xarray datetime accessor now returns DataArrays, not scalars) - Replace deprecated Dataset.dims[] with Dataset.sizes[] for dimension lengths to avoid FutureWarning in xarray >= 2024.10 - Add missing datetime import in mimic_lma.py - Handle empty datasets gracefully in get_lutevents() by returning early with an empty lutevent_id dimension - Use assert_allclose instead of assert_equal for floating point comparisons in test_event_lut.py to account for precision limits https://claude.ai/code/session_01J4PoNVYX96Tdw2uaDGgptc
Ignore downloaded GLM test data files https://claude.ai/code/session_01J4PoNVYX96Tdw2uaDGgptc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.