add json connector

[anzarwani]

Added JSON connector as an enhancement.
Testing is pending as I am facing some issues with module loading, will fix it soon.

[theweaklink]

Hi Anzarwani,

awesome to have a PR for a new element! And thanks for making it similar to existing input elements. We haven't put much guidance on PR yet but it's very close from the start, well done!

I will start the code review comments but in the meantime, here some points to consider:

• does this element require to be "dynamic", i-e other elements (such as dropdown) would depend on it through expressions?
  • if not, then it's probably easier to use pd.read_json(file_input(...)) that would avoid the new element and allows you to get your app right away on the Cloud.
  • if dynamic is expected, would you mind showing a use case with a small code snippet/example?
• for dynamic elements, to be processed on OneCode Cloud, it requires a specific handling there, the initial thought was through metadata() but it is not completely the case yet => just beware that there would be some time required on our end before deploying the dynamic processor on the Cloud.

Thanks for any answer you can share.

[theweaklink]

extra blank line to be removed

[theweaklink]

causes flake8 error:
onecode/base/enums.py:126:1: W293 blank line contains whitespace

[theweaklink]

Would you be ok renaming the component to JsonTableReader or JsonRowReader or similar?
The expected JSON is a table-like which is a subset of the variety of JSON. I am afraid JSONReader would be misleading in the sense it would tackle any JSON (even non-table-like).

[anzarwani]

Hi

Sorry I had been busy with production issues at work. Please give me some time, I will walk through the comments and the code, and accordingly update you here.

[theweaklink]

no worries and no rush :)
whenever it's a good time for you

[theweaklink]

this file is only necessary if there are emulations tests. I would either drop it, or add emulations test (the former being easier ;-))

[theweaklink]

Some comments related to failing CI:

• Elements must be Camel Case so JSONReader => JsonReader but following comment here => suggestion is JsonTableReader or JsonRowReader
• Need to add a new entry to the changelog MD
• Flake8 error

Thanks a lot for the PR, let me know what you think about all the comments.
cheers