Repository navigation
A registered data source is usable at once - #294
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Wayland Yang <wayland0916@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registering a data source created it but granted it to nobody, so mounting it into a base answered "not authorised" until someone clicked "grant to workspace" on the card. Workspaces are invisible in the UI (a single-tenant deployment has exactly one), so that step asked people to authorise something they had never seen.
POST /datasourcesnow grants the new source to every workspace the registering user belongs to, right after the insert. The explicit grant/revoke endpoints are unchanged, so narrowing is still possible from the card.cargo fmt,cargo clippy -D warningspass.🤖 Generated with Claude Code