Repository navigation
The class form has room to breathe, and confirmations wear the house style - #288
Merged
Merged
Conversation
…style Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Wayland Yang <wayland0916@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four things noticed while using the ontology editor and the graph, none of them with an issue of their own.
MultiSearchSelectpositioned the magnifier attop-1/2of the whole component, but the component also holds a row of picked chips or an empty-state line above the input, so half-height landed above the box. The icon and the input now share their ownrelativewrapper, so the icon centres on the input regardless of what sits above it.confirm()dialogs replaced with the house dialog. Graph → entity panel → "Merge in" and KB Settings → Members → "Deactivate" both used the browser's own confirm, which looks like nothing else in the app. Both now go throughDangerConfirmwithout a typed unlock (merge is revertible; deactivation is reversible from the Deactivated accounts list), the same light-confirm shape Library uses for re-extraction. Noconfirm()calls remain inweb/.Verification
In the browser against a live backend: both class-picker icons report the same centre-line as their inputs; the description textarea's computed min-height is 144 px; the disjoint hint reads "None declared yet"; the value-type dropdown lists Text, Number, Date, Boolean; "Merge in" on an entity with two namesakes opens the house dialog ("Merge entities … Cancel / Merge in") and Cancel dismisses it; "Deactivate" on a member does the same.
pnpm buildpasses.🤖 Generated with Claude Code