Skip to content

The class form has room to breathe, and confirmations wear the house style - #288

Merged
WaylandYang merged 1 commit into
devfrom
fix/class-form-breathes
Sep 4, 2026
Merged

WaylandYang merged 1 commit into
devfrom
fix/class-form-breathes

Conversation

@WaylandYang

Copy link
Copy Markdown
Contributor

Four things noticed while using the ontology editor and the graph, none of them with an issue of their own.

  • The search icon in class pickers floated above the input. MultiSearchSelect positioned the magnifier at top-1/2 of the whole component, but the component also holds a row of picked chips or an empty-state line above the input, so half-height landed above the box. The icon and the input now share their own relative wrapper, so the icon centres on the input regardless of what sits above it.
  • The description textareas were cramped. The class form's went from a 4.5 rem minimum to 9 rem, the smaller one from 3.5 to 6; both still resize. The description is fed straight into the extraction prompt, so it deserves room.
  • Two native confirm() dialogs replaced with the house dialog. Graph → entity panel → "Merge in" and KB Settings → Members → "Deactivate" both used the browser's own confirm, which looks like nothing else in the app. Both now go through DangerConfirm without a typed unlock (merge is revertible; deactivation is reversible from the Deactivated accounts list), the same light-confirm shape Library uses for re-extraction. No confirm() calls remain in web/.
  • Two labels. The disjoint picker's empty hint "No class excluded" read as if something had been filtered; it now says "None declared yet". The attribute value type "Yes / no" is called "Boolean", which is what it is.

Verification

In the browser against a live backend: both class-picker icons report the same centre-line as their inputs; the description textarea's computed min-height is 144 px; the disjoint hint reads "None declared yet"; the value-type dropdown lists Text, Number, Date, Boolean; "Merge in" on an entity with two namesakes opens the house dialog ("Merge entities … Cancel / Merge in") and Cancel dismisses it; "Deactivate" on a member does the same. pnpm build passes.

🤖 Generated with Claude Code

…style

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Wayland Yang <wayland0916@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant