Repository navigation
Stop time-word scoring when its pipeline misses the readiness deadline - #1174
Merged
WaylandYang merged 3 commits intoOct 10, 2026
Merged
WaylandYang merged 3 commits into
WaylandYang merged 3 commits into
Conversation
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Wayland Yang <wayland0916@gmail.com>
WaylandYang
approved these changes
Oct 10, 2026
WaylandYang
left a comment
WaylandYang
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this. Confirmed: after either wait ran out the bench scored anyway, so unfinished work was counted as a miss. This matches what the other benches do since #1005. I removed the added test file, since CI runs only scripts/bench/lib.test.mjs and it would not be exercised; the fix itself is taken as you wrote it. Thanks again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both readiness loops previously fell through after their attempt limits, producing normal coverage and repeatability scores while documents or extraction jobs were still pending. Require each phase to reach its completed condition before scoring, and report an explicit timeout otherwise. Completed pipelines still produce reports.
Validation: node --test scripts/bench/timewords.readiness.test.mjs (3 tests pass; 2 regression failures on the original source). Offline subprocess fixtures replace only the external service/process boundary. No database or live-network validation is claimed.