Skip to content

Write extraction failure diagnostics in English - #1112

Merged
WaylandYang merged 2 commits into
deeplethe:devfrom
Aschenbath:fix/localize-source-extraction-errors
Oct 9, 2026
Merged

WaylandYang merged 2 commits into
deeplethe:devfrom
Aschenbath:fix/localize-source-extraction-errors

Conversation

@Aschenbath

@Aschenbath Aschenbath commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Why

Fixes #1105. Graph-extraction failures are displayed as stored, so the server's Chinese chunk and retry summaries appear inside an English failure dialog.

This follows the maintainer's requested English-diagnostic approach. It touches the helper involved in #1095 and should follow that fix; the balance-handling change remains with its assigned contributor.

What changes

  • Write transient-retry reasons, exhausted-retry context, chunk-failure details and the incomplete-attempt summary in English.
  • Keep the attempted/failed counts, example chunk IDs, omitted count and original provider/parser diagnostics.
  • Update the existing assertions and document that previously stored errors retain their original text until another failed attempt replaces them.

The change is limited to diagnostic wording. Error types, retry decisions and the stored/API shape stay the same.

How it was checked

  • cargo fmt --all --check
  • cargo test --locked -p utopia-llm --lib: 47 tests passed on Linux/Rust 1.99.
  • Chromium smoke check with synthetic API responses: Library displays and copies the new English diagnostic in both interface languages.
  • CI passed: workspace formatting/Clippy, cargo test --workspace with PostgreSQL and Poppler required, workspace build, migration/replay checks, and frontend tests/build.

Before review

  • Every commit is signed off (git commit -s)
  • cargo fmt --all --check, cargo clippy --workspace --all-targets -- -D warnings and cargo test --workspace pass (CI)

Signed-off-by: Nash Aschenbath <wwh86696@163.com>
@Aschenbath
Aschenbath marked this pull request as ready for review October 9, 2026 04:39
… the history of the change

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Wayland Yang <wayland0916@gmail.com>

@WaylandYang WaylandYang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking up #1105 so quickly.

The change is right and stays inside its scope: the retry reasons, the chunk labels and the per-attempt summary are now English, the counts and example ids are kept, and nothing about retry decisions moves.

One edit, pushed to your branch (42dc140): the note in docs/pipeline.md now says what is stored in four lines, without the history of the change. That history is in this PR.

Merging when CI is green. Thanks again.

@WaylandYang
WaylandYang merged commit 46e2f3d into deeplethe:dev Oct 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants