Repository navigation
Write extraction failure diagnostics in English - #1112
Merged
WaylandYang merged 2 commits intoOct 9, 2026
Merged
Conversation
Signed-off-by: Nash Aschenbath <wwh86696@163.com>
Aschenbath
marked this pull request as ready for review
October 9, 2026 04:39
… the history of the change Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Wayland Yang <wayland0916@gmail.com>
WaylandYang
approved these changes
Oct 9, 2026
WaylandYang
left a comment
Contributor
There was a problem hiding this comment.
Thank you for picking up #1105 so quickly.
The change is right and stays inside its scope: the retry reasons, the chunk labels and the per-attempt summary are now English, the counts and example ids are kept, and nothing about retry decisions moves.
One edit, pushed to your branch (42dc140): the note in docs/pipeline.md now says what is stored in four lines, without the history of the change. That history is in this PR.
Merging when CI is green. Thanks again.
This was referenced Oct 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #1105. Graph-extraction failures are displayed as stored, so the server's Chinese chunk and retry summaries appear inside an English failure dialog.
This follows the maintainer's requested English-diagnostic approach. It touches the helper involved in #1095 and should follow that fix; the balance-handling change remains with its assigned contributor.
What changes
The change is limited to diagnostic wording. Error types, retry decisions and the stored/API shape stay the same.
How it was checked
cargo fmt --all --checkcargo test --locked -p utopia-llm --lib: 47 tests passed on Linux/Rust 1.99.cargo test --workspacewith PostgreSQL and Poppler required, workspace build, migration/replay checks, and frontend tests/build.Before review
git commit -s)cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warningsandcargo test --workspacepass (CI)