Skip to content

Duplicated error message when adding invalid connection string #921

Closed

Description

@MatheusCylo
Image

As shown in the screenshot, the same error message can be triggered twice by clicking both "Test connection" and "Add data source".

Steps to reproduce:

  1. Create a new knowledge base, or use an existing one.
  2. Go to the data source configuration (/admin?tab=datasources)
  3. Click "+ Add data source"
  4. On the "Engine" dropdown field, select "Connection string"
  5. Add any text to the field "name" (this, alongside the following step, enable the "Add data source" button)
  6. On the field "connection string", add a string with an unrecognized engine prefix (in the screenshot, I've used "na://")
  7. Click both "Test connection" and "Add data source", in any order.

Activity

  1. WaylandYang commented on Sep 25, 2026

    @WaylandYang
    Contributor

    Confirmed, and thanks for the exact steps. The dialog kept a separate error line for Test connection and for Add data source, so both actions on the same bad string showed the same message twice. #925 makes it report one outcome at a time: starting either action clears the other's result, and editing a field or changing the engine clears both. It lands on dev once CI passes and will be in the next release candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions