Skip to content

Conversation

@agibsonccc
Copy link
Contributor

@agibsonccc agibsonccc commented Apr 18, 2025

What changes were proposed in this pull request?

This is a follow up to the previous PR with the rebase applied.
This introduces the new sharding to the samediff file format to overcome the hard limits of flatbuffers.

@treo here's the rebease.

How was this patch tested?

A new large samediff serialization test.

Quick checklist

The following checklist helps ensure your PR is complete:

  • [X ] Eclipse Contributor Agreement signed, and signed commits - see IP Requirements page for details
  • [X ] Reviewed the Contributing Guidelines and followed the steps within.
  • [X ] Created tests for any significant new code additions.
  • [ X] Relevant tests for your changes are passing.

@agibsonccc agibsonccc requested a review from treo April 18, 2025 09:35
@agibsonccc agibsonccc merged commit 50f230e into master Apr 18, 2025
1 check passed
@agibsonccc agibsonccc deleted the ag_samediff_serde branch April 18, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants