Skip to content

Conversation

@agibsonccc
Copy link
Contributor

@agibsonccc agibsonccc commented Feb 16, 2025

What changes were proposed in this pull request?

99% compiler warnings changes
Removes unused methods in string/shape utils

How was this patch tested?

This is part of a series of PRs that were created from running benchmarks and troubleshooting some very mysterious segfaults via race conditions and undefined behavior.

Quick checklist

The following checklist helps ensure your PR is complete:

  • [X ] Eclipse Contributor Agreement signed, and signed commits - see IP Requirements page for details
  • [ X] Reviewed the Contributing Guidelines and followed the steps within.
  • [ X] Created tests for any significant new code additions.
  • [ X] Relevant tests for your changes are passing.

Clean up string and shape utils
@agibsonccc agibsonccc requested a review from treo February 16, 2025 02:00
@agibsonccc agibsonccc merged commit 9d274cf into master Feb 17, 2025
1 check passed
@agibsonccc agibsonccc deleted the ag_utils_changes branch February 17, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants