Skip to content

pin httpx as a workaround for issue#308#309

Open
CarloDePieri wants to merge 18 commits intodeepjyoti30:unstablefrom
CarloDePieri:master
Open

pin httpx as a workaround for issue#308#309
CarloDePieri wants to merge 18 commits intodeepjyoti30:unstablefrom
CarloDePieri:master

Conversation

@CarloDePieri
Copy link

@CarloDePieri CarloDePieri commented Jan 27, 2025

newer version of httpx seems to be breaking youtube-search-python

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

  • Searched the bugtracker for similar pull requests
  • Read ytmdl coding conventions and adjusted the code to meet them
  • Checked the code with pylama
  • Made the pull request to the unstable branch (I have NOT: the setup.py there - and the whole branch for that matter - seems to be outdated, and this change does not impact code directly. I will if you prefer to)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New feature

Description of your pull request and other information

As discussed in #308, pinning the httpx version would be a temporary workaround while a long term fix is being developed.

@stale
Copy link

stale bot commented Jun 27, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs for another 7 days. Thank you for your contributions.

@stale stale bot added the stale label Jun 27, 2025
@CarloDePieri
Copy link
Author

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs for another 7 days. Thank you for your contributions.

good bot. but the issue seems still present

@stale stale bot removed the stale label Jul 3, 2025
Copy link
Owner

@deepjyoti30 deepjyoti30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@deepjyoti30 deepjyoti30 changed the base branch from master to unstable July 5, 2025 09:59
@deepjyoti30
Copy link
Owner

@CarloDePieri Can you rebase to unstable and update the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants