Skip to content

Conversation

tipame
Copy link
Contributor

@tipame tipame commented Sep 16, 2025

Description

#3799

@tipame tipame requested review from zachgk and a team as code owners September 16, 2025 06:24
Copy link
Contributor

@frankfliu frankfliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate your contribution. This looks great.

We don't have integration test for this function. would you mind add an test in NDArrayElementComparisonOpTest?

@tipame
Copy link
Contributor Author

tipame commented Sep 16, 2025

I'll add a test

@tipame
Copy link
Contributor Author

tipame commented Sep 16, 2025

It's not clear - the integration test NDArrayElementComparisonOpTest looks like something general, but an implementation has been added only for the Pytorch engine.

@tipame tipame force-pushed the percentile branch 2 times, most recently from 7ea77a4 to f7081c4 Compare September 16, 2025 11:12
@frankfliu
Copy link
Contributor

@tipame

Would you please run:

./gradlew fJ

@frankfliu
Copy link
Contributor

@tipame

Not sure why window build failed. Maybe related to recent gradle changes. Can you rebase on master branch?

@tipame
Copy link
Contributor Author

tipame commented Sep 19, 2025

It looks like the native library build for Windows is broken (not by this commit)

@frankfliu
Copy link
Contributor

@tipame

You are right, there is bug in build.gradle.kts file caused by gradle 9.0.0 upgrade.

Would you please apply the following patch:

diff --git a/engines/pytorch/pytorch-native/build.gradle.kts b/engines/pytorch/pytorch-native/build.gradle.kts
index 4e00b1160..b6b989a77 100644
--- a/engines/pytorch/pytorch-native/build.gradle.kts
+++ b/engines/pytorch/pytorch-native/build.gradle.kts
@@ -65,6 +65,10 @@ tasks {
             }
             into(ciDir)
         }
+        val dll = ciDir / "Release/djl_torch.dll"
+        if (dll.exists()) {
+            dll.renameTo(ciDir / "djl_torch.dll")
+        }
     }
 
     fun downloadBuildAndroid() {

@frankfliu
Copy link
Contributor

@tipame see: #3802 3802

@tipame
Copy link
Contributor Author

tipame commented Sep 22, 2025

I applied the patch but now it crashed on the Ubuntu build. I didn't understand what the problem was from the logs.
Is there a forced rebuild button here?

@frankfliu
Copy link
Contributor

@tipame
I think it's github issue. the patch has been merged. You can just rebase and push again to trigger another build.

@xyang16 xyang16 merged commit 735b3a3 into deepjavalibrary:master Sep 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants