-
Notifications
You must be signed in to change notification settings - Fork 720
Added percentile implementation for Pytorch engine #3800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate your contribution. This looks great.
We don't have integration test for this function. would you mind add an test in NDArrayElementComparisonOpTest
?
I'll add a test |
It's not clear - the integration test NDArrayElementComparisonOpTest looks like something general, but an implementation has been added only for the Pytorch engine. |
7ea77a4
to
f7081c4
Compare
Would you please run:
|
Not sure why window build failed. Maybe related to recent gradle changes. Can you rebase on master branch? |
It looks like the native library build for Windows is broken (not by this commit) |
You are right, there is bug in build.gradle.kts file caused by gradle 9.0.0 upgrade. Would you please apply the following patch:
|
I applied the patch but now it crashed on the Ubuntu build. I didn't understand what the problem was from the logs. |
@tipame |
Description
#3799