Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[djl-convert] Fixes huggingface model converter #3440

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners August 24, 2024 20:51
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.72%. Comparing base (5c418be) to head (3a684e7).
Report is 36 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3440      +/-   ##
============================================
+ Coverage     72.57%   74.72%   +2.15%     
- Complexity     7377     7518     +141     
============================================
  Files           669      669              
  Lines         32658    32658              
  Branches       3474     3474              
============================================
+ Hits          23701    24404     +703     
+ Misses         7319     6579     -740     
- Partials       1638     1675      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankfliu frankfliu changed the title [djl-convert] Fixes huggingface mocel converter [djl-convert] Fixes huggingface model converter Aug 26, 2024
@frankfliu frankfliu merged commit 94bce4a into deepjavalibrary:master Aug 26, 2024
5 checks passed
@frankfliu frankfliu deleted the convert branch August 26, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants