Refactored Identifiers #3381
Merged
Refactored Identifiers #3381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
reviewed
Aug 4, 2024
| @@ -197,7 +197,7 @@ public Trainer newTrainer(TrainingConfig trainingConfig) { | |||
| // Unfreeze parameters if training directly | |||
| block.freezeParameters( | |||
| false, | |||
| p -> p.getType() != Type.RUNNING_MEAN && p.getType() != Type.RUNNING_VAR); | |||
| param -> param.getType() != Type.RUNNING_MEAN && param.getType() != Type.RUNNING_VAR); | |||
There was a problem hiding this comment.
short parameter name in lambda is very common. I don't think this change is necessary.
| @@ -91,8 +91,8 @@ public void load(Path modelPath, String prefix, Map<String, ?> options) | |||
| configProto = (ConfigProto) config; | |||
| } else if (config instanceof String) { | |||
| try { | |||
| byte[] buf = Base64.getDecoder().decode((String) config); | |||
| configProto = ConfigProto.parseFrom(buf); | |||
| byte[] buffer = Base64.getDecoder().decode((String) config); | |||
There was a problem hiding this comment.
The same here, buf is pretty common short name for buffer
| @@ -72,8 +72,8 @@ public static void testGetterSetters(Class<?> baseClass) | |||
| continue; | |||
| } | |||
|
|
|||
| Method[] methods = clazz.getDeclaredMethods(); | |||
| for (Method method : methods) { | |||
| Method[] declaredMethods = clazz.getDeclaredMethods(); | |||
There was a problem hiding this comment.
declaredMethods might be more clear, but I don't feel methods is a bad local variable name.
frankfliu
force-pushed
the
Identifier-Refactorings
branch
from
6156c82
to
b74c490
Compare
frankfliu
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored certain identifiers in the code - expanded certain variable names according to its usage in the code to make them more descriptive. Meanwhile, changed "testOffLine" to "testOffline" as "Offline" is a single word, to conform to Java naming conventions.