[python] Update lmi-dist #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
reviewed
Jul 26, 2023
| mpi4py sentencepiece einops accelerate==${accelerate_version} bitsandbytes==${bitsandbytes_version}\ | ||
| diffusers[torch]==${diffusers_version} peft==${peft_version} opencv-contrib-python-headless safetensors scipy && \ | ||
| scripts/install_flash_attn.sh && \ | ||
| scripts/install_flash_attn_v2.sh && \ |
There was a problem hiding this comment.
Some machine don't support flash attention v2, so have to install both. Then it will determine which version to use at runtime.
lanking520
reviewed
Jul 26, 2023
| @@ -16,6 +16,7 @@ ARG python_version=3.9 | |||
| ARG torch_version=2.0.1 | |||
| ARG torch_vision_version=0.15.2 | |||
| ARG deepspeed_wheel="https://publish.djl.ai/deepspeed/deepspeed-nightly-py2.py3-none-any.whl" | |||
| ARG vllm_wheel="https://publish.djl.ai/vllm/vllm-0.0.0-cp39-cp39-linux_x86_64.whl" | |||
There was a problem hiding this comment.
I would check with @frankfliu , vllm introduced a lot of dependencies you don't want, that's why we didn't have it for V5. If you already understand this, please feel free to ignore
There was a problem hiding this comment.
Yes, I discussed with Frank about this yesterday. So this solution to install wheel will not install the dependencies.
There was a problem hiding this comment.
Total size increase is 0.5GB.
xyang16
changed the title
xyang16
force-pushed
the
update
branch
2 times, most recently
from
c25f61f to
ee213c1
Compare
frankfliu
approved these changes
Jul 26, 2023
KexinFeng
pushed a commit
to KexinFeng/djl-serving-forked
that referenced
this pull request
Aug 16, 2023
* [python] Upgrade the dependency for lmi-dist * [python] Upgrade lmi-dist
KexinFeng
pushed a commit
to KexinFeng/djl-serving-forked
that referenced
this pull request
Aug 16, 2023
* [python] Upgrade the dependency for lmi-dist * [python] Upgrade lmi-dist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about