[WIP] Unit test with random seed failure #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanking520
suggested changes
Jul 6, 2023
KexinFeng
force-pushed
the
unit_test_random_seed
branch
from
6ade6c0 to
3c233c5
Compare
lanking520
approved these changes
Jul 6, 2023
frankfliu
suggested changes
Jul 6, 2023
engines/python/setup/djl_python/scheduler/seq_batch_scheduler.py
Outdated
Show resolved
Hide resolved
engines/python/setup/djl_python/scheduler/seq_batch_scheduler.py
Outdated
Show resolved
Hide resolved
KexinFeng
changed the title
KexinFeng
changed the title
KexinFeng
changed the title
KexinFeng
force-pushed
the
unit_test_random_seed
branch
from
31296e5 to
b7c8f83
Compare
KexinFeng
force-pushed
the
unit_test_random_seed
branch
from
b7c8f83 to
5d583a0
Compare
lanking520
approved these changes
Jul 6, 2023
frankfliu
approved these changes
Jul 6, 2023
KexinFeng
added a commit
to KexinFeng/djl-serving-forked
that referenced
this pull request
Aug 16, 2023
KexinFeng
added a commit
to KexinFeng/djl-serving-forked
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to enable the unit test for the sampling autoregressive searching. The assertion is true when locally testing it. But in the PR continueous test, the assertion becomes false.
Update:
Now the assertion in the unit test passes the PR test. However, local test will fail at that assertion.
So the issue is, after setting the random seed, the outputs, even though fixed, are different between local testing and PR testing.