Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor createVirtualEnv() #875

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Refactor createVirtualEnv() #875

merged 2 commits into from
Jun 28, 2023

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners June 28, 2023 07:22
@frankfliu frankfliu merged commit 96e2792 into deepjavalibrary:master Jun 28, 2023
@frankfliu frankfliu deleted the env branch June 28, 2023 18:05
KexinFeng pushed a commit to KexinFeng/djl-serving-forked that referenced this pull request Aug 16, 2023
@frankfliu
Refactor createVirtualEnv() (deepjavalibrary#875)
06510b1 
* Refactor createVirtualEnv()

* Updates unittest
KexinFeng pushed a commit to KexinFeng/djl-serving-forked that referenced this pull request Aug 16, 2023
@frankfliu @KexinFeng
Refactor createVirtualEnv() (deepjavalibrary#875)
85d8593 
* Refactor createVirtualEnv()

* Updates unittest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyang16 xyang16 xyang16 approved these changes

@lanking520 lanking520 lanking520 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankfliu @lanking520 @xyang16