Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[partition] Improves partition error message #826

Merged
merged 1 commit into from
Jun 10, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions serving/docker/partition/properties_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,12 +140,14 @@ def set_and_validate_entry_point(self):
self.properties['option.entryPoint'] = 'model.py'
else:
engine = self.properties.get('engine')
if engine == "DeepSpeed":
if engine is None:
raise ValueError("Please specify engine")
elif engine.lower() == "deepspeed":
entry_point = "djl_python.deepspeed"
elif engine == "FasterTransformer":
elif engine.lower() == "fastertransformer":
entry_point = "djl_python.fastertransformer"
else:
raise ValueError("Please specify engine")
raise ValueError(f"Invalid engine: {engine}")
self.properties['option.entryPoint'] = entry_point
elif entry_point.lower().startswith('http'):
logging.info(f'Downloading entrypoint file.')
Expand Down