[Stream] use huggingface standard generation for tnx #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
reviewed
May 31, 2023
| @@ -23,10 +23,10 @@ def get_stream_generator(execution_engine: str): | |||
| ## execution_engine passed to this function is not the same engine specified in serving.properties | |||
| ## in djl-serving. For e.g Accelerate and neuronx use Python as the engine serving.properties | |||
| ## The engine here refers to backend model parallel framework. | |||
| if execution_engine in {"DeepSpeed", "Accelerate"}: | |||
| if execution_engine in { | |||
There was a problem hiding this comment.
should this be a list ["DeepSpeed", "Accelerate", "transformers-neuronx"] ?
There was a problem hiding this comment.
A set will be better?
frankfliu
approved these changes
May 31, 2023
KexinFeng
pushed a commit
to KexinFeng/djl-serving-forked
that referenced
this pull request
Aug 16, 2023
KexinFeng
pushed a commit
to KexinFeng/djl-serving-forked
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add TNX streaming generation for HuggingFace No-KV interface