Don't mount model dir for no code tests #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanking520
reviewed
Apr 28, 2023
| ./launch_container.sh deepjavalibrary/djl-serving:$DJLSERVING_DOCKER_TAG $PWD/models deepspeed \ | ||
| serve -m test=file:/opt/ml/model/test/ | ||
| ./launch_container.sh deepjavalibrary/djl-serving:$DJLSERVING_DOCKER_TAG no_code deepspeed \ | ||
| serve -m test=file:/opt/ml/model/ |
There was a problem hiding this comment.
remove -m, we also don't need this
There was a problem hiding this comment.
if we remove this, is there a way to specify the model name as test? I initially removed this and then ran into issues with client.py expecting the model name to be test, but by default the model will be called model.
There was a problem hiding this comment.
We can definitely update client.py, but I thought this was easier
There was a problem hiding this comment.
ok, let's leave this now
There was a problem hiding this comment.
We need specify the model name here. we don't have a way to call management API without model name (this is not supported by SageMaker).
lanking520
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test run https://github.com/deepjavalibrary/djl-serving/actions/runs/4834079393/jobs/8614905302.
Although it failed, the issue was with the model name when it was registered (default is model, we expect test). I updated the workflow to match the expected model name on the client side.
Functionally, the test run showed these changes worked.