[serving] Adds workflow model loading for SageMaker #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return parse(uri, new InputStreamReader(input, StandardCharsets.UTF_8)); | ||
| public static WorkflowDefinition parse(String name, URI uri) throws IOException { | ||
| String type = FilenameUtils.getFileExtension(Objects.requireNonNull(uri.toString())); | ||
| try (InputStream is = uri.toURL().openStream(); |
Check failure
Code scanning / CodeQL
Server-side request forgery
1. Removed global preferences for workflow definition 2. Updated README
zachgk
reviewed
Apr 25, 2023
| for (Entry<String, ModelInfo<Input, Output>> emd : models.entrySet()) { | ||
| ModelInfo<Input, Output> md = emd.getValue(); | ||
| md.setId(emd.getKey()); | ||
| md.setQueueSize(firstValid(md.getQueueSize(), queueSize, wlmc.getJobQueueSize())); |
There was a problem hiding this comment.
Is there a reason we are removing these parameters from the workflow?
There was a problem hiding this comment.
- global settings is just the default value, per model setting is override the settings in
serving.properties. this is a bit confusing - In most cases (especially on GPU), each model will have different per model settings
- We only covered a subset of per model settings.
There was a problem hiding this comment.
I would still lean towards keeping it.
- It's a basic system of more specific rules override less specific.
Global < workflow settings < model serving.properties < workflow model settings - The workflow has both settings for all models in the workflow and for particular models
- Do you mean
loadOnDevices? It might be worth adding it, then.
I think having this is still useful. When importing models defined externally (like in model hub), this still allows defining some model properties without having to do something difficult to introduce the serving.properties.
But, I can see the argument towards removing it and I don't think it's too important. I'll just approve it and leave it up to you
zachgk
approved these changes
Apr 25, 2023
frankfliu
added a commit
that referenced
this pull request
May 18, 2023
* [serving] Adds workflow model loading for SageMaker 1. Removed global preferences for workflow definition 2. Updated README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about