[serving] deprecate s3Url and replace it with model_id #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanking520
reviewed
Mar 23, 2023
tests/integration/llm/prepare.py
Outdated
| @@ -8,13 +8,13 @@ | |||
|
|
|||
| ds_aot_list = { | |||
| "opt-6.7b": { | |||
| "option.s3url": "s3://djl-llm/opt-6b7/", | |||
| "option.model_id": "s3://djl-llm/opt-6b7/", | |||
There was a problem hiding this comment.
let's keep an s3 url option here. To keep this test in the loop
| @@ -40,13 +40,14 @@ def __init__(self, props_manager): | |||
| self.download_model_from_s3() | |||
|
|
|||
| def download_model_from_s3(self): | |||
| if "s3url" not in self.properties: | |||
| model_id = self.properties.get("model_id") | |||
| if not model_id or model_id.startswith("s3://"): | |||
There was a problem hiding this comment.
you mean not model_id.startswith?
sindhuvahinis
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about