[fix] optimum token selector do sample defaults #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engines/python/setup/djl_python/transformers_neuronx_scheduler/optimum_neuron_scheduler.py
Show resolved
Hide resolved
tosterberg
force-pushed
the
testing-clean-up
branch
from
415b23c to
de17649
Compare
tosterberg
commented
Oct 15, 2024
sindhuvahinis
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing error with default behavior when do_sample is true but neither top_p / top_k are set. Fix added for defaulting the prefill/decode bool to None inside the NiaveRollingBatcher to support the updates to Optimum modeling. Additionally, removing stale model tests.