Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ib] fix docker env file write location #2073

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

tosterberg
Copy link
Contributor

@tosterberg tosterberg commented Jun 17, 2024

Description

Fix issue where env variables passed using IB are not being added to the container when running IB.

Current implementation will add the docker_env file to ./model/test relative to the current working directory, however, the docker_env needs to be in the same directory as the ./launch_container.sh when it is run in order to add the env variables to the container. Since the paths were already relative in the script I updated the file right to current working directory ./ rather than ./model/test

@tosterberg tosterberg requested review from zachgk, frankfliu and a team as code owners June 17, 2024 20:59
@tosterberg tosterberg merged commit 676bee9 into deepjavalibrary:master Jun 17, 2024
8 checks passed
@tosterberg tosterberg deleted the update-ib branch June 17, 2024 21:11
@tosterberg tosterberg restored the update-ib branch June 17, 2024 21:11
@tosterberg tosterberg deleted the update-ib branch June 17, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants