Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug with duplicate models when HF_MODEL_ID points to model store #2054

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

siddvenk
Copy link
Contributor

Description

If customer has mounted model artifacts to /opt/ml/model, and also specified HF_MODEL_ID=/opt/ml/model, then the container fails to startup with

ERROR ModelServer Invalid configuration
ai.djl.serving.http.BadRequestException: Workflow model is already registered.
	at ai.djl.serving.models.ModelManager.registerWorkflow(ModelManager.java:92) ~[serving-0.28.0.jar:?]
	at ai.djl.serving.ModelServer.initModelStore(ModelServer.java:444) ~[serving-0.28.0.jar:?]
	at ai.djl.serving.ModelServer.start(ModelServer.java:208) ~[serving-0.28.0.jar:?]
	at ai.djl.serving.ModelServer.startAndWait(ModelServer.java:174) ~[serving-0.28.0.jar:?]
	at ai.djl.serving.ModelServer.main(ModelServer.java:143) [serving-0.28.0.jar:?]

Issue is that when adding to the list or urls, we returned the local path which is different than the url so it looks like 2 different models, but at workflow register level they are the same

@siddvenk siddvenk requested review from zachgk, frankfliu and a team as code owners June 12, 2024 22:33
@siddvenk siddvenk merged commit eae8c78 into deepjavalibrary:master Jun 12, 2024
7 checks passed
@siddvenk siddvenk deleted the hf-env branch July 3, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants