Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Seq2Seq model fix for lmi-dist #1991

Merged
merged 1 commit into from
May 30, 2024
Merged

[fix] Seq2Seq model fix for lmi-dist #1991

merged 1 commit into from
May 30, 2024

Conversation

maaquib
Copy link
Contributor

@maaquib maaquib commented May 30, 2024

Description

Seq2Seq model fix for lmi-dist
Pending build of RE with the corresponding backend fix

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@maaquib maaquib marked this pull request as ready for review May 30, 2024 02:32
@maaquib maaquib requested review from zachgk, frankfliu and a team as code owners May 30, 2024 02:32
@maaquib maaquib merged commit ed4888c into master May 30, 2024
27 of 28 checks passed
@maaquib maaquib deleted the flan_fix branch May 30, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tosterberg tosterberg tosterberg approved these changes

@davidthomas426 davidthomas426 davidthomas426 approved these changes

@sindhuvahinis sindhuvahinis Awaiting requested review from sindhuvahinis

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

@frankfliu frankfliu Awaiting requested review from frankfliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maaquib @davidthomas426 @tosterberg