Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Revert extra parameters and added unit tests cases #1948

Merged
merged 2 commits into from
May 21, 2024
Merged

[fix] Revert extra parameters and added unit tests cases #1948

merged 2 commits into from
May 21, 2024

Conversation

sindhuvahinis
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@sindhuvahinis sindhuvahinis requested review from zachgk, frankfliu and a team as code owners May 21, 2024 20:38
@sindhuvahinis sindhuvahinis changed the title [fix] Fix extra parameters and added unit tests cases [fix] Refactor extra parameters and added unit tests cases May 21, 2024
@lanking520 lanking520 merged commit e87642d into deepjavalibrary:master May 21, 2024
8 checks passed
@sindhuvahinis sindhuvahinis changed the title [fix] Refactor extra parameters and added unit tests cases [fix] Revert extra parameters and added unit tests cases May 22, 2024
@sindhuvahinis sindhuvahinis deleted the ut branch June 20, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanking520 lanking520 lanking520 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

@frankfliu frankfliu Awaiting requested review from frankfliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sindhuvahinis @lanking520